publishing: add rules for 1.17 and remove for 1.13 #84588
Merged
+315
−218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
cncf-cla: yes
|
/kind cleanup |
k8s-ci-robot
added
kind/cleanup
|
Thanks @nikhita! /lgtm |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, nikhita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest
…On Thu, Oct 31, 2019 at 5:53 PM Kubernetes Prow Robot < ***@***.***> wrote:
@nikhita <https://github.com/nikhita>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-e2e-gce 852cd98
<852cd98>
link
<https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/84588/pull-kubernetes-e2e-gce/1189867949662408704/> /test
pull-kubernetes-e2e-gce
Full PR test history
<https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=84588>. Your
PR dashboard <https://gubernator.k8s.io/pr/nikhita>. Please help us cut
down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#84588?email_source=notifications&email_token=AD24BUEXOIF2BZRMUFSHKBDQRLE4DA5CNFSM4JHIRAU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECXRRHI#issuecomment-548346013>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD24BUGI4UTTDHY7P4TDWFLQRLE4DANCNFSM4JHIRAUQ>
.
|
|
/retest
…On Thu, Oct 31, 2019 at 6:16 PM Kubernetes Prow Robot < ***@***.***> wrote:
@nikhita <https://github.com/nikhita>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-e2e-gce 852cd98
<852cd98>
link
<https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/84588/pull-kubernetes-e2e-gce/1189882295834644480/> /test
pull-kubernetes-e2e-gce
Full PR test history
<https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=84588>. Your
PR dashboard <https://gubernator.k8s.io/pr/nikhita>. Please help us cut
down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#84588?email_source=notifications&email_token=AD24BUEZXC3JNHL4GBHXUL3QRLHSBA5CNFSM4JHIRAU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECXTVIQ#issuecomment-548354722>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD24BUDRSRFX3KT6NMK5DV3QRLHSBANCNFSM4JHIRAUQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://groups.google.com/forum/#!topic/kubernetes-dev/MDDmj5NQQzk
Closes: #84532
The
release-1.17branch has been created. This PR adds rules for 1.17 and removes the 1.13 ones as it isn't supported anymore./hold
until it is confirmed that it is safe to remove the 1.13 rules
/assign @sttts @dims
/cc @justaugustus @tpepper
Does this PR introduce a user-facing change?: