Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apiextensions: validate list-type and map-type "atomic" #84722

Merged
merged 5 commits into from Nov 16, 2019
Merged

apiextensions: validate list-type and map-type "atomic" #84722

merged 5 commits into from Nov 16, 2019

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Nov 4, 2019

/kind bug

Implement the documented API semantics of list-type and map-type atomic to reject non-atomic sub-types.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 4, 2019
@sttts sttts added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 4, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 4, 2019
@sttts sttts added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Nov 4, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 4, 2019
@sttts sttts added area/custom-resources needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. kind/bug Categorizes issue or PR as related to a bug. labels Nov 4, 2019
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 4, 2019
@sttts sttts removed the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 4, 2019
@sttts sttts closed this Nov 4, 2019
@sttts sttts reopened this Nov 6, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 6, 2019
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@sttts sttts added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 7, 2019
@sttts
Copy link
Contributor Author

sttts commented Nov 7, 2019

/assign @apelisse

I need you confirmation that my understanding of "atomic" is correct here.

@sttts sttts force-pushed the sttts-crd-list-map-type-atomic-validations branch 2 times, most recently from c2e14f9 to 5b13a54 Compare November 8, 2019 16:02
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Nov 15, 2019
@liggitt
Copy link
Member

liggitt commented Nov 15, 2019

/milestone v1.17
This is fixing a bug I would consider release blocking

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.18, v1.17 Nov 15, 2019
@sttts sttts force-pushed the sttts-crd-list-map-type-atomic-validations branch from 19b1ab1 to 4570038 Compare November 15, 2019 16:15
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 15, 2019
@sttts sttts force-pushed the sttts-crd-list-map-type-atomic-validations branch from 4570038 to 61ae424 Compare November 15, 2019 16:19
@liggitt
Copy link
Member

liggitt commented Nov 15, 2019

one comment on nil check, lgtm otherwise

@sttts sttts force-pushed the sttts-crd-list-map-type-atomic-validations branch from 61ae424 to b3b15a9 Compare November 15, 2019 21:40
@liggitt
Copy link
Member

liggitt commented Nov 15, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 8436dde into kubernetes:master Nov 16, 2019
@sttts sttts mentioned this pull request Nov 16, 2019
Merged
@liggitt
Copy link
Member

liggitt commented Nov 16, 2019

release note should clarify this is for CRs and should use the actual API field names (x-kubernetes-…)

@liggitt liggitt moved this from Bugs/Cleanup/Tests to Complete in Custom Resource Definitions Feb 17, 2020
anik120 added a commit to anik120/operator-lifecycle-manager that referenced this pull request Mar 19, 2020
@anik120
chore(apis): Regenerate API types in accordance with openapi3 specifi…
fb47fbe 
…cation

In kube 1.17, the openapi structural schema validation was updated to validate
CRDs according to the documented API semantics of x-kubernetes-list-type and
x-kubernetes-map-type atomic to reject non-atomic sub-types. This PR updates
the API types to follow the specification.
See kubernetes/kubernetes#84722 for more details.
anik120 added a commit to anik120/operator-lifecycle-manager that referenced this pull request Mar 19, 2020
@anik120
chore(apis): Regenerate API types in accordance with openapi3 specifi…
f8f75f6 
…cation

In kube 1.17, the openapi structural schema validation was updated to validate
CRDs according to the documented API semantics of x-kubernetes-list-type and
x-kubernetes-map-type atomic to reject non-atomic sub-types. This PR updates
the API types to follow the specification.
See kubernetes/kubernetes#84722 for more details.
@liggitt liggitt mentioned this pull request Dec 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@apelisse apelisse apelisse left review comments

@davidopp davidopp Awaiting requested review from davidopp

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@liggitt liggitt

@apelisse apelisse

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/custom-resources cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Custom Resource Definitions
Complete
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sttts @fejta-bot @josiahbjorgaard @liggitt @k8s-ci-robot @apelisse