New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate kubelet custom metrics to stability framework part 1 #84907
migrate kubelet custom metrics to stability framework part 1 #84907
Conversation
ccbf61c
to
03d9592
Compare
Unit test failed as we need another functionality, the one like /hold [edit] This rely on some functionalities for custom collector testing and they are in #84919 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign |
Update bazel by hack/update-bazel.sh
03d9592
to
e4a128a
Compare
/test pull-kubernetes-e2e-gce-storage-slow /assign @saad-ali |
Great work! |
/assign @saad-ali @kubernetes/sig-node-pr-reviews |
@RainbowMango The v1.17 code freeze is coming up on 11/14 at 5PM pacific time. This PR will need to be merged before then for v1.17. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dashpole, derekwaynecarr, RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @RainbowMango , would these metrics be visible only in v1.17 ? not before or after ? I dont see ONLY these volume metrics in kubelet scrape on v1.15. I had to ask here since i had no response to #89733 |
No, this PR didn't change the visibility of metrics. |
Oh ok, only these metrics fail to be visible on k8s v1.15, could you please assist on how to troubleshoot this issue on this PR or my PR? Are there any other metrics to determine pv consumption? |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Currently, custom metrics emitted from kubelet do not offer any stability guarantees.
And #83062 tries to make it possible to do so.
About metrics stability please refer to KEP .
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
There are still some custom metrics under
pkg/kubelet/server
that I'd prefer to do it later.Because it's a little different(can't make it one-line migration) and I'm trying to find a way to deal with them.
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/priority important-soon
/milestone v1.17