Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of EvenPodSpread (priority and predicate) #84936

Open
alculquicondor opened this issue Nov 7, 2019 · 2 comments

Comments

@alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented Nov 7, 2019

In the light of a new performance test that compares EvenPodSpread with SelectorSpread (#84606), it seems that EvenPodSpread can be faster.

Let's investigate if we can achieve parity by carefully building the data structures.

/sig scheduling

@gongguan

This comment has been minimized.

Copy link
Contributor

@gongguan gongguan commented Nov 9, 2019

buildPodTopologySpreadMap is expensive and will affect the result. Could it be initialized once outside the loop?

podTopologySpreadMap: buildPodTopologySpreadMap(pod, filteredNodes, snapshot.NodeInfoList),

@alculquicondor

This comment has been minimized.

Copy link
Member Author

@alculquicondor alculquicondor commented Nov 9, 2019

That goes against the purpose of the test: an end-to-end comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.