Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garbage collector should orphan ControllerRevisions created by Statefulset when deleteOptions.OrphanDependents is true #84982

Open
cofyc opened this issue Nov 8, 2019 · 1 comment · May be fixed by #84984
Assignees

Comments

@cofyc
Copy link
Member

@cofyc cofyc commented Nov 8, 2019

What happened:

  • Create a stateful set
  • Delete with propagationPolicy=Orphan
  • ControllerRevisions owned by stateful set will be deleted

What you expected to happen:

ControllerRevisions owned by stateful set should be orphaned.

How to reproduce it (as minimally and precisely as possible):

  • Create a stateful set
  • Delete with propagationPolicy=Orphan
  • Check controller revisions owned by this statefulset

Anything else we need to know?:

Same as #42639.
Before adopting controller revisions, we should check the deletion timestamp like what DaemonSet does.

xref: #42938 #47084

@cofyc cofyc added the kind/bug label Nov 8, 2019
@cofyc

This comment has been minimized.

Copy link
Member Author

@cofyc cofyc commented Nov 8, 2019

/sigs apps
/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.