Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Garbage collector should orphan ControllerRevisions created by Statefulset when deleteOptions.OrphanDependents is true #84982

Closed
cofyc opened this issue Nov 8, 2019 · 2 comments · Fixed by #84984
Closed

Garbage collector should orphan ControllerRevisions created by Statefulset when deleteOptions.OrphanDependents is true #84982

cofyc opened this issue Nov 8, 2019 · 2 comments · Fixed by #84984
Assignees
@cofyc
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/apps Categorizes an issue or PR as relevant to SIG Apps.

Comments

@cofyc
Copy link
Member

cofyc commented Nov 8, 2019 •
edited
Loading

What happened:

  • Create a stateful set
  • Delete with propagationPolicy=Orphan
  • ControllerRevisions owned by stateful set will be deleted

What you expected to happen:

ControllerRevisions owned by stateful set should be orphaned.

How to reproduce it (as minimally and precisely as possible):

  • Create a stateful set
  • Delete with propagationPolicy=Orphan
  • Check controller revisions owned by this statefulset

Anything else we need to know?:

Same as #42639.
Before adopting controller revisions, we should check the deletion timestamp like what DaemonSet does.

xref: #42938 #47084
@cofyc cofyc added the kind/bug Categorizes issue or PR as related to a bug. label Nov 8, 2019
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 8, 2019
@cofyc
Copy link
Member Author

cofyc commented Nov 8, 2019

/sigs apps
/assign

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 8, 2019
@cofyc cofyc mentioned this issue Nov 8, 2019
Merged
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cofyc cofyc

Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Projects
None yet
Milestone
No milestone
3 participants
@cofyc @k8s-ci-robot @fejta-bot