Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golint issues in pkg/util/sysctl/testing #85016

Merged
merged 1 commit into from Dec 17, 2019
Merged

Fix golint issues in pkg/util/sysctl/testing #85016

merged 1 commit into from Dec 17, 2019

Conversation

hvaara
Copy link
Contributor

@hvaara hvaara commented Nov 8, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR fixes golint issues in pkg/util/sysctl/testing

Which issue(s) this PR fixes:
Ref #68026

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig testing
/priority backlog
/area code-organization

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/testing Categorizes an issue or PR as relevant to SIG Testing. priority/backlog Higher priority than priority/awaiting-more-evidence. area/code-organization Issues or PRs related to kubernetes code organization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 8, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @hvaara. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 8, 2019
@hvaara
Copy link
Contributor Author

hvaara commented Nov 8, 2019

/assign @lavalamp

@hvaara hvaara force-pushed the fix-golint-pkg-util-sysctl-testing branch from 9e96b79 to e55fc56 Compare November 9, 2019 11:33
@neolit123
Copy link
Member

i don't think these are used anywhere currently:
https://github.com/kubernetes/kubernetes/search?q=%22pkg%2Futil%2Fsysctl%2Ftesting%22&unscoped_q=%22pkg%2Futil%2Fsysctl%2Ftesting%22
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 9, 2019
@hvaara
Copy link
Contributor Author

hvaara commented Nov 9, 2019

Sorry, I don't understand. Can you please explain @neolit123?

@neolit123
Copy link
Member

Sorry, I don't understand. Can you please explain @neolit123?

unless the github search is incorrect, it doesn't seem like the package pkg/util/sysctl/testing
i used anywhere. the lint fix seems OK.

@hvaara
Copy link
Contributor Author

hvaara commented Nov 9, 2019

Sorry, I don't understand. Can you please explain @neolit123?

unless the github search is incorrect, it doesn't seem like the package pkg/util/sysctl/testing
i used anywhere. the lint fix seems OK.

Isn't it used here?
image

@neolit123
Copy link
Member

oddly this query returned no .go results earlier https://github.com/kubernetes/kubernetes/search?q=%22pkg%2Futil%2Fsysctl%2Ftesting%22&unscoped_q=%22pkg%2Futil%2Fsysctl%2Ftesting%22

@hvaara
Copy link
Contributor Author

hvaara commented Nov 9, 2019

I have it open in two tabs and actually see different results! 🤔
image
image

/retest

@hvaara
Copy link
Contributor Author

hvaara commented Nov 9, 2019

/retest

@hvaara
Copy link
Contributor Author

hvaara commented Dec 3, 2019

/assign @fejta @thockin

@lavalamp
Copy link
Member

lavalamp commented Dec 3, 2019

/lgtm
/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2019
fejta
fejta approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@hvaara
Copy link
Contributor Author

hvaara commented Dec 4, 2019

Hi @lavalamp
Thanks for the review! I think there was a typo in the /approved command (extra d at the end). Can you please add it again?

@fejta
Copy link
Contributor

fejta commented Dec 5, 2019

/assign brendandburns dchen1107 lavalamp smarterclayton thockin

thockin
thockin reviewed Dec 16, 2019
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, hvaara, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit fb0956c into kubernetes:master Dec 17, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 17, 2019
@hvaara hvaara deleted the fix-golint-pkg-util-sysctl-testing branch December 17, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@fejta fejta fejta approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

@zmerlynn zmerlynn Awaiting requested review from zmerlynn

Assignees

@lavalamp lavalamp

@fejta fejta

@smarterclayton smarterclayton

@thockin thockin

@brendandburns brendandburns

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-organization Issues or PRs related to kubernetes code organization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@hvaara @k8s-ci-robot @neolit123 @lavalamp @fejta @fejta-bot @thockin @smarterclayton @brendandburns @dchen1107