Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote apiserver.config.k8s.io/v1, kind=AdmissionConfiguration #85098

Merged
merged 1 commit into from Nov 13, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Nov 11, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

  • This promotes apiserver.config.k8s.io/v1alpha1, kind=AdmissionConfiguration to apiserver.config.k8s.io/v1, kind=AdmissionConfiguration with no schema changes. This was added in v1.6.0 and has been in use with no changes since then.
  • Docs update in Update docs for AdmissionConfiguration v1 website#17548

There are efforts in progress to graduate individual admission configurations (like resourcequota), and those require plumbing information through this config type.

Does this PR introduce a user-facing change?:

kube-apiserver: The `AdmissionConfiguration` type accepted by `--admission-control-config-file` has been promoted to `apiserver.config.k8s.io/v1` with no schema changes.

/sig api-machinery
/cc @deads2k @derekwaynecarr
fyi @ahg-g @ravisantoshgudimetla

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 11, 2019
@k8s-ci-robot k8s-ci-robot added area/apiserver kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 11, 2019
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt liggitt force-pushed the admission-config-v1 branch 2 times, most recently from c55395f to 095d520 Compare November 11, 2019 18:19
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member Author

liggitt commented Nov 12, 2019

/priority important-soon

related to #76310

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 12, 2019
@liggitt
Copy link
Member Author

liggitt commented Nov 12, 2019

/retest

@liggitt liggitt changed the title Promote AdmissionConfiguration type to apiserver.config.k8s.io/v1 Promote apiserver.config.k8s.io/v1, kind=AdmissionConfiguration Nov 12, 2019
@liggitt liggitt added this to the v1.17 milestone Nov 12, 2019
Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold

for @deads2k to review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2019
@deads2k
Copy link
Contributor

deads2k commented Nov 13, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2019
@ahg-g
Copy link
Member

ahg-g commented Nov 13, 2019

/retest

@liggitt
Copy link
Member Author

liggitt commented Nov 13, 2019

the pull-kubernetes-node-e2e-containerd failure is known, not a flake, non-blocking, and being worked on - #85040

@ahg-g
Copy link
Member

ahg-g commented Nov 13, 2019

the pull-kubernetes-node-e2e-containerd failure is known, not a flake, non-blocking, and being worked on - #85040

This was failing since yesterday, more than few PRs get merged since this started to fail, retesting few times actually works.

/test pull-kubernetes-node-e2e-containerd

@k8s-ci-robot
Copy link
Contributor

@liggitt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-node-e2e-containerd 1234290 link /test pull-kubernetes-node-e2e-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants