New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote apiserver.config.k8s.io/v1, kind=AdmissionConfiguration #85098
Conversation
16588b5
to
bdf8b0e
Compare
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
c55395f
to
095d520
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
095d520
to
1234290
Compare
/priority important-soon related to #76310 |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold cancel |
/retest |
the pull-kubernetes-node-e2e-containerd failure is known, not a flake, non-blocking, and being worked on - #85040 |
This was failing since yesterday, more than few PRs get merged since this started to fail, retesting few times actually works. /test pull-kubernetes-node-e2e-containerd |
@liggitt: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
apiserver.config.k8s.io/v1alpha1, kind=AdmissionConfiguration
toapiserver.config.k8s.io/v1, kind=AdmissionConfiguration
with no schema changes. This was added in v1.6.0 and has been in use with no changes since then.There are efforts in progress to graduate individual admission configurations (like resourcequota), and those require plumbing information through this config type.
Does this PR introduce a user-facing change?:
/sig api-machinery
/cc @deads2k @derekwaynecarr
fyi @ahg-g @ravisantoshgudimetla