Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote apiserver.config.k8s.io/v1, kind=ResourceQuotaConfiguration #85099

Merged
merged 1 commit into from Nov 13, 2019
Merged

Promote apiserver.config.k8s.io/v1, kind=ResourceQuotaConfiguration #85099

merged 1 commit into from Nov 13, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Nov 11, 2019 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

  • This promotes resourcequota.admission.k8s.io/v1beta1, kind=Configuration to apiserver.config.k8s.io/v1, kind=ResourceQuotaConfiguration
    • The apiserver.config.k8s.io group for generic API server configuration was determined after the configuration type was introduced
    • The Configuration suffix is used consistently for top-level configuration types
  • Docs updated in Update docs for v1 resource quota configuration website#17547

Does this PR introduce a user-facing change?:

kube-apiserver: The `ResourceQuota` admission plugin configuration referenced from `--admission-control-config-file` admission config has been promoted to `apiVersion: apiserver.config.k8s.io/v1`, `kind: ResourceQuotaConfiguration` with no schema changes.

/cc @derekwaynecarr @deads2k @ahg-g @ravisantoshgudimetla

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 11, 2019
@liggitt
Copy link
Member Author

liggitt commented Nov 11, 2019

/retest

@liggitt liggitt changed the title WIP - Promote resource quota admission configuration to v1 Promote resource quota admission configuration to v1 Nov 11, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member Author

liggitt commented Nov 12, 2019

/sig api-machinery
/priority important-soon
/milestone v1.17

related to #76310

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Nov 12, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 12, 2019
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 12, 2019
This was referenced Nov 12, 2019
Merged
Merged
@liggitt liggitt changed the title Promote resource quota admission configuration to v1 Promote apiserver.config.k8s.io/v1, kind=ResourceQuotaConfiguration Nov 12, 2019
ravisantoshgudimetla
ravisantoshgudimetla approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @liggitt for working on this :)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2019
@liggitt
Copy link
Member Author

liggitt commented Nov 12, 2019

/hold for @deads2k ack

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2019
deads2k
deads2k reviewed Nov 13, 2019
View reviewed changes
plugin/pkg/admission/resourcequota/config_test.go
}},
},
{
name: "valid v1 config",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@deads2k
Copy link
Contributor

deads2k commented Nov 13, 2019

Since this is logically generic, moving the group makes sense. It does raise some questions about introducing a v2, but sparse versions should work.

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2019
@ahg-g
Copy link
Member

ahg-g commented Nov 13, 2019

/retest

@liggitt
Copy link
Member Author

liggitt commented Nov 13, 2019

the pull-kubernetes-node-e2e-containerd failure is known, not a flake, non-blocking, and being worked on - #85040

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 195664d into kubernetes:master Nov 13, 2019
@liggitt liggitt deleted the quota-config-v1 branch November 14, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@ravisantoshgudimetla ravisantoshgudimetla ravisantoshgudimetla approved these changes

@ahg-g ahg-g Awaiting requested review from ahg-g

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@deads2k deads2k

@ravisantoshgudimetla ravisantoshgudimetla

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@liggitt @k8s-ci-robot @deads2k @ahg-g @fejta-bot @ravisantoshgudimetla