Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow show hidden metrics in kube-proxy #85279

Merged
merged 3 commits into from Dec 18, 2019
Merged

Allow show hidden metrics in kube-proxy #85279

merged 3 commits into from Dec 18, 2019

Conversation

RainbowMango
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add a flag --show-hidden-metrics-for-version to kube-proxy for show hidden metrics.

Which issue(s) this PR fixes:
Part of #85270

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

New flag `--show-hidden-metrics-for-version` in kube-proxy can be used to show all hidden metrics that deprecated in the previous minor release.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/20190404-kubernetes-control-plane-metrics-stability.md

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 14, 2019
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@RainbowMango RainbowMango mentioned this pull request Nov 14, 2019
Closed
5 tasks
@RainbowMango
Copy link
Member Author

/test pull-kubernetes-node-e2e-containerd

1 similar comment
@RainbowMango
Copy link
Member Author

/test pull-kubernetes-node-e2e-containerd

@RainbowMango
Copy link
Member Author

/hold
We need to solve the issue first.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2019
@RainbowMango
Copy link
Member Author

/assign @thockin
/cc @brancz @logicalhan

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2019
thockin
thockin reviewed Dec 2, 2019
View reviewed changes
cmd/kube-proxy/app/server.go
@@ -149,6 +149,12 @@ func (o *Options) AddFlags(fs *pflag.FlagSet) {
fs.StringVar(&o.master, "master", o.master, "The address of the Kubernetes API server (overrides any value in kubeconfig)")
fs.StringVar(&o.hostnameOverride, "hostname-override", o.hostnameOverride, "If non-empty, will use this string as identification instead of the actual hostname.")
fs.StringVar(&o.config.IPVS.Scheduler, "ipvs-scheduler", o.config.IPVS.Scheduler, "The ipvs scheduler type when proxy mode is ipvs")
fs.StringVar(&o.config.ShowHiddenMetricsForVersion, "show-hidden-metrics-for-version", o.config.ShowHiddenMetricsForVersion,
"The previous version for which you want to show hidden metrics. "+
"Only the previous minor version is meaningful, other values will not be allowed. "+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is part of a larger effort, but this comment is confusing to me.

If it only allows the previous version, why do I have to specify a version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, this flag is an escape hatch, it intends to be used by admins if they were not able to react to the earlier deprecation warnings.

Second of all, we don't want admins to be excessive depend on this flag, otherwise, they may fail to notice deprecate message from the next release.

Here is an example: why-not-bool-flag

@thockin

thockin
thockin reviewed Dec 17, 2019
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 17, 2019
@ahg-g
Copy link
Member

ahg-g commented Dec 17, 2019

/test pull-kubernetes-bazel-test

@ahg-g
Copy link
Member

ahg-g commented Dec 17, 2019

/hold

I think this PR is failing pull-kubernetes-bazel-test in the merge queue

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2019
@RainbowMango
Copy link
Member Author

I think this PR is failing pull-kubernetes-bazel-test in the merge queue

Is there an issue tracking this failing test? Or, what can I do for this?

@ahg-g
Copy link
Member

ahg-g commented Dec 17, 2019

I think this PR is failing pull-kubernetes-bazel-test in the merge queue

Is there an issue tracking this failing test? Or, what can I do for this?

you need to fix your PR, please look at the reason here: https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/85279/pull-kubernetes-bazel-test/1206771457862930432

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2019
@RainbowMango
Copy link
Member Author

Just rebase master and force-push, let's see what happens.

I don't know why bazel test failing in merge pool, no idea from logs, it's weird.

@RainbowMango
Copy link
Member Author

pull-kubernetes-bazel-test failing due to new unit test added by #84688.

I haven't go through the whole PR, @tahsinrahman can you help take a look?

@RainbowMango
Copy link
Member Author

New commit is specially for fix unit tests.

@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Dec 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RainbowMango
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@brancz
Copy link
Member

brancz commented Dec 18, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2019
@RainbowMango
Copy link
Member Author

/hold cancel
@ahg-g Thanks for your help. Let's continue after unit test has been fixed.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2019
@RainbowMango
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit 2796ff8 into kubernetes:master Dec 18, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 18, 2019
@RainbowMango RainbowMango deleted the pr_add_metrics_flag_to_proxy branch December 18, 2019 09:28
@k8s-ci-robot
Copy link
Contributor

@RainbowMango: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce 6b33a77 link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@bowei bowei Awaiting requested review from bowei

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@brancz brancz Awaiting requested review from brancz

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@brancz brancz

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@RainbowMango @fejta-bot @ahg-g @k8s-ci-robot @brancz @thockin