Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.16: apiextensions: validate list-type and map-type "atomic" #85385

Merged
merged 5 commits into from Dec 2, 2019
Merged

1.16: apiextensions: validate list-type and map-type "atomic" #85385

merged 5 commits into from Dec 2, 2019

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Nov 16, 2019 •
edited

Backport of #84722.

/kind bug

For x-kubernetes-list-type=set a scalar or atomic item type is now required, as documented. Persisted, invalid data is tolerated.

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Nov 16, 2019
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 16, 2019
@sttts sttts force-pushed the sttts-crd-list-map-type-atomic-validations-1.16 branch from 8f42f50 to 4e09710 Compare November 16, 2019 14:51
@sttts sttts added area/custom-resources sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Nov 16, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 16, 2019
@sttts sttts added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 16, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 16, 2019
@sttts sttts changed the title 1.16: apiextensions: validate list-type map+set uniqueness in CRs 1.16: apiextensions: validate list-type and map-type "atomic" Nov 16, 2019
@sttts sttts force-pushed the sttts-crd-list-map-type-atomic-validations-1.16 branch from 4e09710 to af837c1 Compare November 16, 2019 15:03
@liggitt
Copy link
Member

liggitt commented Nov 16, 2019

/lgtm
/approve

This tolerates existing persisted data, and is important to ensure documented API behavior.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2019
@liggitt
Copy link
Member

liggitt commented Nov 16, 2019

release note should clarify this is for CRs and should use the actual API field names (x-kubernetes-…)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2019
@sttts
Copy link
Contributor Author

sttts commented Nov 16, 2019

@liggitt updated the release note.

@sttts
Copy link
Contributor Author

sttts commented Nov 16, 2019

cc @kubernetes/patch-release-team

@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 2, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit dca9b41 into kubernetes:release-1.16 Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/custom-resources cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sttts @liggitt @k8s-ci-robot @tpepper