-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APIAggregator#PrepareRun should return exported type #85398
Comments
/sig api-machinery |
this is a deisgned "option ----> config --(complete) --> completedConfig --(new)--> instance" code flow. the other way round, i remember we agreed refactoring and applying it throughout the codebase somewhere else offline.. |
/assign @sttts |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
What would you like to be added:
Looking at the usage of APIAggregator#PrepareRun, the first return value is used as runnable.
We should export runnable type (Runnable) and declare the return type for APIAggregator#PrepareRun as Runnable.
Why is this needed:
APIAggregator#PrepareRun returns preparedAPIAggregator which is unexported.
The text was updated successfully, but these errors were encountered: