Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIAggregator#PrepareRun should return exported type #85398

Closed
tedyu opened this issue Nov 17, 2019 · 6 comments
Closed

APIAggregator#PrepareRun should return exported type #85398

tedyu opened this issue Nov 17, 2019 · 6 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@tedyu
Copy link
Contributor

tedyu commented Nov 17, 2019

What would you like to be added:
Looking at the usage of APIAggregator#PrepareRun, the first return value is used as runnable.
We should export runnable type (Runnable) and declare the return type for APIAggregator#PrepareRun as Runnable.

Why is this needed:
APIAggregator#PrepareRun returns preparedAPIAggregator which is unexported.

@tedyu tedyu added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 17, 2019
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 17, 2019
@tedyu
Copy link
Contributor Author

tedyu commented Nov 18, 2019

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 18, 2019
@liggitt
Copy link
Member

liggitt commented Nov 18, 2019

cc @sttts @deads2k

@yue9944882
Copy link
Member

this is a deisgned "option ----> config --(complete) --> completedConfig --(new)--> instance" code flow. the other way round, i remember we agreed refactoring and applying it throughout the codebase somewhere else offline..

@fedebongio
Copy link
Contributor

/assign @sttts

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 2, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 1, 2020
@tedyu tedyu closed this as completed Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Development

No branches or pull requests

7 participants