Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default value for TEST_CLUSTER_LOG_LEVEL and KUBE_GCE_INSTANCE_PREFIX #85508

Merged
merged 1 commit into from Nov 25, 2019

Conversation

notpad
Copy link
Contributor

@notpad notpad commented Nov 21, 2019

What type of PR is this?

/kind bug

What this PR does / why we need it:

Set default value for variable TEST_CLUSTER_LOG_LEVEL and KUBE_GCE_INSTANCE_PREFIX, so that we can run test/kubemark/start-kubemark.sh directly without predefining these two variables.

Which issue(s) this PR fixes:

Fixes #85507

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/sig testing
/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 21, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @notpad. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mm4tt
Copy link
Contributor

mm4tt commented Nov 21, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 21, 2019
@notpad
Copy link
Contributor Author

notpad commented Nov 22, 2019

/assign @shyamjvs

@mm4tt
Copy link
Contributor

mm4tt commented Nov 22, 2019

There is no need to assign it further, I already approved it but in won't merge in 1.17 (it's not a critical bug fix).
It will merge once the code freeze is lifted.

@notpad
Copy link
Contributor Author

notpad commented Nov 22, 2019

I see. Thanks!

@notpad
Copy link
Contributor Author

notpad commented Nov 24, 2019

There is no need to assign it further, I already approved it but in won't merge in 1.17 (it's not a critical bug fix).
It will merge once the code freeze is lifted.

@mm4tt When will the code freeze end? I think this PR doesn't have lgtm and approve label yet.

@mm4tt
Copy link
Contributor

mm4tt commented Nov 24, 2019

Sorry, I thought I already approved this. I must have mistaken this PR with one of others of yours

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mm4tt, notpad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit e6b0dbb into kubernetes:master Nov 25, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

start-kubemark.sh fails with unbound variable
4 participants