New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default value for TEST_CLUSTER_LOG_LEVEL and KUBE_GCE_INSTANCE_PREFIX #85508
Conversation
Hi @notpad. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
d16e6a0
to
8b951ed
Compare
/ok-to-test |
/assign @shyamjvs |
There is no need to assign it further, I already approved it but in won't merge in 1.17 (it's not a critical bug fix). |
I see. Thanks! |
@mm4tt When will the code freeze end? I think this PR doesn't have lgtm and approve label yet. |
Sorry, I thought I already approved this. I must have mistaken this PR with one of others of yours /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mm4tt, notpad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Set default value for variable
TEST_CLUSTER_LOG_LEVEL
andKUBE_GCE_INSTANCE_PREFIX
, so that we can runtest/kubemark/start-kubemark.sh
directly without predefining these two variables.Which issue(s) this PR fixes:
Fixes #85507
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig testing
/sig cluster-lifecycle