Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl/drain: Add context support #85574

Merged
merged 1 commit into from Dec 2, 2019
Merged

kubectl/drain: Add context support #85574

merged 1 commit into from Dec 2, 2019

Conversation

michaelgugino
Copy link
Contributor

@michaelgugino michaelgugino commented Nov 23, 2019 •
edited

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
This commits allows specifying a context.Context
in the Helper type. This context is utilized to
cancel waitForDelete.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [Other doc]: https://github.com/kubernetes/enhancements/issues/1339

@michaelgugino
kubectl/drain: Add context support
8682e90 
This commits allows specifying a context.Context
in the Helper type. This context is utilized to
cancel waitForDelete.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 23, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @michaelgugino. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 23, 2019
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 23, 2019
@michaelgugino michaelgugino mentioned this pull request Nov 24, 2019
Closed
@neolit123
Copy link
Member

/ok-to-test
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 24, 2019
@seans3
Copy link
Contributor

seans3 commented Dec 2, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelgugino, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3e7c787 into kubernetes:master Dec 2, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 2, 2019
alexander-demicev pushed a commit to alexander-demicev/machine-api-operator that referenced this pull request Jan 13, 2020
Cherry-pick add option skip-wait-for-delete-timeout changes
1546dd8 
This PR moves code from 2 upstream PRs to this repo. It adds support for context(used to cancel waitForDelete) and
allows to ignore pods that have a DeletionTimestamp older than a user-provided.
See below PRs for more detailed description:

kubernetes/kubernetes#85577
kubernetes/kubernetes#85574
@alexander-demicev alexander-demicev mentioned this pull request Jan 13, 2020
Merged
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#85574 from mgugino-upstream-stage/kubec…
03dd8a5 
…tl-drain-ctx

kubectl/drain: Add context support

Kubernetes-commit: 3e7c787
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adohe-zz adohe-zz Awaiting requested review from adohe-zz

@dixudx dixudx Awaiting requested review from dixudx

Assignees

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michaelgugino @k8s-ci-robot @neolit123 @seans3