Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-winio module version from 0.4.11 to 0.4.14 #85739

Merged
merged 1 commit into from Dec 6, 2019

Conversation

wawa0210
Copy link
Contributor

@wawa0210 wawa0210 commented Nov 29, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind cleanup

What this PR does / why we need it:

Update go mod go-winio version to Improve windows ListenPipe stability . The kubernetes code as https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/util/util_windows.go#L38-L54.
go-winio fixed this in 0.4.13. An a race condition where ListenPipe can fail due to concurrent DialPipe calls. We can check the details through https://github.com/microsoft/go-winio/releases/tag/v0.4.13

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update go-winio module version from 0.4.11 to 0.4.14

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@jterry75
/sig windows

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 29, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @wawa0210. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/windows Categorizes an issue or PR as relevant to SIG Windows. area/dependency Issues or PRs related to dependency changes and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 29, 2019
@k8s-ci-robot k8s-ci-robot requested review from lavalamp, thockin and a team November 29, 2019 00:24
@tanjunchen
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 29, 2019
@jterry75
Copy link

jterry75 commented Dec 2, 2019

LGTM (not a maintainer)

@BenTheElder
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2019
@wawa0210
Copy link
Contributor Author

wawa0210 commented Dec 4, 2019

/assign @lavalamp
/assign @liggitt

@PatrickLang PatrickLang added this to Backlog (v1.18) in SIG-Windows Dec 6, 2019
@PatrickLang PatrickLang moved this from Backlog (v1.18) to In Progress (v1.18) in SIG-Windows Dec 6, 2019
@liggitt
Copy link
Member

liggitt commented Dec 6, 2019

/approve
/kind bug
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Dec 6, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Dec 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, liggitt, wawa0210

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 220e2ce into kubernetes:master Dec 6, 2019
SIG-Windows automation moved this from In Progress (v1.18) to Done (v1.18) Dec 6, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 6, 2019
@wawa0210 wawa0210 deleted the update-go-winio branch December 7, 2019 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants