Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix staticcheck in test/e2e/cloud/ #85751

Merged
merged 1 commit into from Dec 6, 2019
Merged

fix staticcheck in test/e2e/cloud/ #85751

merged 1 commit into from Dec 6, 2019

Conversation

tanjunchen
Copy link
Member

@tanjunchen tanjunchen commented Nov 29, 2019 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fix static check failures in test/e2e/cloud/

Which issue(s) this PR fixes:

Ref: #81657

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 29, 2019
@tanjunchen
Copy link
Member Author

/priority backlog
/release-note-none
/cc @liggitt

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. priority/backlog Higher priority than priority/awaiting-more-evidence. area/test sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 29, 2019
@tanjunchen
Copy link
Member Author

/assign @sttts

@tanjunchen tanjunchen changed the title fix staticcheck in test/e2e/auth/ and test/e2e/cloud/ fix staticcheck in test/e2e/cloud/ Dec 2, 2019
@tanjunchen
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@tanjunchen
Copy link
Member Author

@neolit123

SataQiu
SataQiu reviewed Dec 6, 2019
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tanjunchen
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2019
@tanjunchen
Copy link
Member Author

/cc @liggitt can you reciew this pr?thx

@liggitt
Copy link
Member

liggitt commented Dec 6, 2019

please remove the package from the staticcheck failures file

@tanjunchen
Copy link
Member Author

@liggitt
test/cloud not in hack/.staticchek_failures,i use staticcheck not hack/.. command.

@liggitt
Copy link
Member

liggitt commented Dec 6, 2019

@liggitt
test/cloud not in hack/.staticchek_failures,i use staticcheck not hack/.. command.

oh, I see. in the future, I would recommend focusing on the issues identified by the hack static check command

/lgtm
/approve

@tanjunchen
Copy link
Member Author

@liggitt
get it.Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit d49ce6a into kubernetes:master Dec 6, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 6, 2019
@tanjunchen tanjunchen deleted the fix-staticcheck-test-e2e-auth-cloud branch January 4, 2020 06:06
@liggitt liggitt removed the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SataQiu SataQiu SataQiu left review comments

@cheftako cheftako Awaiting requested review from cheftako

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@sttts sttts

@liggitt liggitt

@SataQiu SataQiu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tanjunchen @liggitt @k8s-ci-robot @SataQiu @sttts