Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert ExpectEqual(err, nil) to ExpectNoError(err) #85934

Merged
merged 1 commit into from Dec 5, 2019
Merged

Convert ExpectEqual(err, nil) to ExpectNoError(err) #85934

merged 1 commit into from Dec 5, 2019

Conversation

xueweiz
Copy link

@xueweiz xueweiz commented Dec 5, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation

/kind failing-test

/kind feature
/kind flake

What this PR does / why we need it:
Convert ExpectEqual(err, nil) pattern to ExpectNoError(err) for all e2e tests.

Which issue(s) this PR fixes:

Fixes #85933

Special notes for your reviewer:

No behavioral change introduced.

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 5, 2019
@xueweiz
Copy link
Author

xueweiz commented Dec 5, 2019

This is to fix #85933 introduced by #85787

/cc @tanjunchen
/cc @oomichi
/cc @tallclair
/cc @wangzhen127

@xueweiz
Copy link
Author

xueweiz commented Dec 5, 2019

/assign @oomichi

@xueweiz
Copy link
Author

xueweiz commented Dec 5, 2019

I searched for regex pattern .*ExpectEqual.*nil.*, which should be an exhaustive list of all bugs related to #85933 , and fixed all the affected ones.

alejandrox1
alejandrox1 reviewed Dec 5, 2019
View reviewed changes
Copy link
Contributor

@alejandrox1 alejandrox1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!
/lgtm
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 5, 2019
@xueweiz xueweiz mentioned this pull request Dec 5, 2019
Merged
@k8s-ci-robot k8s-ci-robot added do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 5, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Dec 5, 2019
@xueweiz
Copy link
Author

xueweiz commented Dec 5, 2019

#85787 was just reverted in #85931. I just rebased this patch on top of master to resolve conflict.

@xueweiz xueweiz mentioned this pull request Dec 5, 2019
Closed
@tanjunchen
Copy link
Member

/test pull-kubernetes-e2e-kind

@xueweiz
Copy link
Author

xueweiz commented Dec 5, 2019

/retest

@claudiubelu
Copy link
Contributor

/lgtm

pretty simple PR, everything passes, no reason not to approve it.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2019
@xueweiz
Copy link
Author

xueweiz commented Dec 5, 2019

/cc @BenTheElder

@BenTheElder
Copy link
Member

/lgtm
/approve

/priority critical-urgent

hmm is it? 🙃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, xueweiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2019
@xueweiz
Copy link
Author

xueweiz commented Dec 5, 2019

hmm is it?

:) it's no longer critical now.

It was critical yesterday, as many CIs were broken (#85933) due to #85787. The PR was reverted in #85931 later yesterday's night, and fixed the CIs. So it's no longer critical now.

@k8s-ci-robot k8s-ci-robot merged commit 4fe4ff8 into kubernetes:master Dec 5, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrox1 alejandrox1 alejandrox1 left review comments

@cheftako cheftako Awaiting requested review from cheftako

@justinsb justinsb Awaiting requested review from justinsb

@oomichi oomichi Awaiting requested review from oomichi

@tallclair tallclair Awaiting requested review from tallclair

@tanjunchen tanjunchen Awaiting requested review from tanjunchen

@wangzhen127 wangzhen127 Awaiting requested review from wangzhen127

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@BenTheElder BenTheElder

@oomichi oomichi

@claudiubelu claudiubelu

@alejandrox1 alejandrox1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

e2e_node tests are failing due to "Refusing to compare <nil> to <nil>"
7 participants
@xueweiz @tanjunchen @claudiubelu @BenTheElder @k8s-ci-robot @alejandrox1 @oomichi