Fix IPv6 addresses lost issue in pure ipv6 vsphere environment

[hubv]

What type of PR is this?

/kind bug

What this PR does / why we need it:
with this bug fix, k8s could get both ipv6/ipv4 addresses from vsphere platform, meanwhile k8s could ignore link-local addresses while retrieves VM’s IP.

VMware tools can collect IP addresses on VM, and provide them to k8s.
those IP addresses contain both ipv4/ipv6 addresses, and some useless link-local addresses
e.g.

From the code
https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/legacy-cloud-providers/vsphere/vsphere.go#L682-L700
we can know that while the provider retrieves VM’s IP, It uses To4() function for all IP addresses from vsphere platform, this function will ignore all ipv6 address, and can't filter out ipv4 link-local addresses.

It will cause IPv6 addresses lost in node status.

[root@henry-c1 ~]# kubectl get nodes -o wide
NAME        STATUS   ROLES    AGE    VERSION   INTERNAL-IP   EXTERNAL-IP   OS-IMAGE                                      KERNEL-VERSION               CONTAINER-RUNTIME
henry-c1    Ready    <none>   6h9m   v1.15.4   <none>        <none>        Red Hat Enterprise Linux Server 7.6 (Maipo)   3.10.0-1062.1.2.el7.x86_64   docker://1.13.1

and we can't use helm in a vsphere pure ipv6 env

[root@henry-c1 ~]# helm install
Error: forwarding ports: error upgrading connection: no preferred addresses found; known addresses: []

In this PR, we use !ParseIP(ip).IsLinkLocalUnicast() to retrieves VM’s IP

we can get ipv6 address in node status by this fix, and can use helm in a pure ipv6 vsphere env

[root@henry-c1 ~]# kubectl get nodes -o wide
NAME        STATUS   ROLES    AGE    VERSION                                  INTERNAL-IP         EXTERNAL-IP         OS-IMAGE                                      KERNEL-VERSION               CONTAINER-RUNTIME
henry-c1    Ready    <none>   2d9h   v1.15.7-beta.0.16+6be749574d9801-dirty   2650:1:87:96::113   2650:1:87:96::113   Red Hat Enterprise Linux Server 7.6 (Maipo)   3.10.0-1062.1.2.el7.x86_64   docker://1.13.1

Which issue(s) this PR fixes:

Fixes #85886 #83584

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix IPv6 addresses lost issue in pure ipv6 vsphere environment

[k8s-ci-robot]

Hi @hubv. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hubv]

please help to review and merge
We are blocking by issue #85886
I think I can fix the issue by this PR
@kubernetes/cloud-provider
/sig cloud-provider
@SandeepPissay @abrarshivani @imkin @dchen1107
Thanks a lot

[hubv]

/assign @BaluDontu

[dims]

/ok-to-test
/priority important-soon

[dims]

/assign @frapposelli

[hubv]

/test pull-kubernetes-e2e-gce-device-plugin-gpu

[frapposelli]

@hubv thanks for this PR!

/lgtm
/approve

/cc @dvonthenen @andrewsykim PTAL, not sure if this was already fixed in out-of-tree

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frapposelli, hubv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/legacy-cloud-providers/vsphere/OWNERS [frapposelli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dvonthenen]

@frapposelli thanks for the heads up! IPv6 support was addressed in the external provider a few weeks back.

[hubv]

/cc
Could someone help to cherry-pick this fix into v1.17.x or v1.16.x?Then we can adopt it before v1.18.
Thank you

[k8s-ci-robot]

@hubv: GitHub didn't allow me to request PR reviews from the following users: hubv.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc
Could someone help to cherry-pick this fix into v1.17.x or v1.16.x?Then we can adopt it before v1.18.
Thank you

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.