Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify intstr.IntValue() behavior #86172

Merged
merged 1 commit into from Jan 15, 2020
Merged

Clarify intstr.IntValue() behavior #86172

merged 1 commit into from Jan 15, 2020

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Dec 11, 2019

What type of PR is this?
/kind cleanup
/kind documentation

What this PR does / why we need it:
Clarifies behavior of intstr.IntValue() when an unparseable string value is held.

Which issue(s) this PR fixes:
Closes #49487

Does this PR introduce a user-facing change?:

NONE

/sig api-machinery
/priority backlog

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/documentation Categorizes issue or PR as related to documentation. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. priority/backlog Higher priority than priority/awaiting-more-evidence. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Dec 11, 2019
@liggitt liggitt mentioned this pull request Dec 11, 2019
Closed
@liggitt
Copy link
Member Author

liggitt commented Jan 14, 2020

/cc @feiskyer

can you review the update in pkg/proxy/winkernel/proxier.go? (it's not a behavior change, just making the current behavior explicit)

feiskyer
feiskyer approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 97d68d0 into kubernetes:master Jan 15, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 15, 2020
@liggitt liggitt deleted the intstr branch January 22, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@madhanrm madhanrm Awaiting requested review from madhanrm

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

(*IntOrString) IntValue() always returns zero when IntOrString is a percentage
3 participants
@liggitt @k8s-ci-robot @feiskyer