Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Snapshot to internal/cache #87165

Merged
merged 2 commits into from Jan 18, 2020
Merged

Move Snapshot to internal/cache #87165

merged 2 commits into from Jan 18, 2020

Conversation

alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented Jan 13, 2020 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The snapshot implementation is highly linked to the Cache. Other users only need the SharedListers interface.

Which issue(s) this PR fixes:

Fixes #87033

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 13, 2020
@alculquicondor
Copy link
Member Author

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 13, 2020
@alculquicondor alculquicondor force-pushed the cleanup/mv_snapshot_2 branch 4 times, most recently from 39d9830 to 5e909d3 Compare January 14, 2020 02:37
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 14, 2020
@alculquicondor
Copy link
Member Author

/retest

@ahg-g
Copy link
Member

ahg-g commented Jan 16, 2020

/cc

@alculquicondor
Copy link
Member Author

This is already ready for review :)

/assign @ahg-g

@alculquicondor
Rename cache's Snapshot to Dump
6a14203 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2020
@ahg-g
Copy link
Member

ahg-g commented Jan 17, 2020

Thanks, please squash.

@alculquicondor
Move Snapshot from nodeinfo/snapshot to internal/cache
f53d7e5 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
@alculquicondor
Copy link
Member Author

Done. But I'm keeping 2 logical commits.

@ahg-g
Copy link
Member

ahg-g commented Jan 17, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2020
@alculquicondor
Copy link
Member Author

/hold for a rebase

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2020
@alculquicondor
Copy link
Member Author

/hold cancel

Sorry, I got confused with my other PR :)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2020
@alculquicondor
Copy link
Member Author

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 3538320 into kubernetes:master Jan 18, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losipiuk losipiuk losipiuk left review comments

@ahg-g ahg-g ahg-g left review comments

@k82cn k82cn Awaiting requested review from k82cn

@wgliang wgliang Awaiting requested review from wgliang

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

[Scheduler] Move snapshot.Snapshot to cache.Snapshot
5 participants
@alculquicondor @ahg-g @k8s-ci-robot @fejta-bot @losipiuk