Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shellcheck warnings/errors in /build/lib/release.sh #87285

Merged
merged 10 commits into from Feb 14, 2020
Merged

Fix shellcheck warnings/errors in /build/lib/release.sh #87285

merged 10 commits into from Feb 14, 2020

Conversation

joakimr-axis
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Fixes the shellcheck failures for /build/lib/release.sh

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 16, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @joakimr-axis. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joakimr-axis joakimr-axis mentioned this pull request Jan 16, 2020
Closed
@joakimr-axis
Copy link
Contributor Author

/assign @fejta

@BenTheElder
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 16, 2020
BenTheElder
BenTheElder reviewed Jan 16, 2020
View reviewed changes
build/lib/release.sh Show resolved Hide resolved
build/lib/release.sh Outdated Show resolved Hide resolved
@fejta
Copy link
Contributor

fejta commented Jan 17, 2020

/unassign
/assign @BenTheElder

@k8s-ci-robot k8s-ci-robot assigned BenTheElder and unassigned fejta Jan 17, 2020
@hwdef
Copy link
Member

hwdef commented Jan 17, 2020

/lgtm for hack

@joakimr-axis
Copy link
Contributor Author

/retest

@joakimr-axis
Copy link
Contributor Author

/test pull-kubernetes-cross

1 similar comment
@joakimr-axis
Copy link
Contributor Author

/test pull-kubernetes-cross

joakimr-axis
joakimr-axis commented Jan 17, 2020
View reviewed changes
build/lib/release.sh Outdated Show resolved Hide resolved
joakimr-axis
joakimr-axis commented Jan 17, 2020
View reviewed changes
build/lib/release.sh Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 17, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 17, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Feb 4, 2020
@joakimr-axis
Copy link
Contributor Author

/test pull-kubernetes-integration

@joakimr-axis
Copy link
Contributor Author

/retest

1 similar comment
@joakimr-axis
Copy link
Contributor Author

/retest

@joakimr-axis
Copy link
Contributor Author

/sig release

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 5, 2020
BenTheElder
BenTheElder reviewed Feb 5, 2020
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would like a compelling reason to switch from [[ ]] to [ ], I'm only aware of reasons you'd want to go the other way, and we're fairly consistent about using [[ ]] in bash scripts.

build/lib/release.sh Outdated Show resolved Hide resolved
build/lib/release.sh Outdated Show resolved Hide resolved
build/lib/release.sh Show resolved Hide resolved
@BenTheElder
Copy link
Member

sorry for the delay https://gubernator.k8s.io/pr/bentheelder 🔥 -- working on that

@joakimr-axis
Copy link
Contributor Author

sorry for the delay https://gubernator.k8s.io/pr/bentheelder -- working on that

No worries!

@BenTheElder
Copy link
Member

/priority important-longterm
taking a reminder to do another pass tomorrow
also dragging in some release types, @justaugustus @tpepper roll up your bash sleeves 🙃

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 5, 2020
@joakimr-axis
Re-adding the [[ as per review comment request
e05f8e6 
Change-Id: I4a2fa687e6ef5c4ebf5c5624a730c32f23b7b134
Signed-off-by: Joakim Roubert <joakimr@axis.com>
@justaugustus
Copy link
Member

/assign @justaugustus @tpepper

@joakimr-axis
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@joakimr-axis
Copy link
Contributor Author

/retest

1 similar comment
@joakimr-axis
Copy link
Contributor Author

/retest

@BenTheElder
Copy link
Member

/approve
generally looks like a great improvement thanks, load shedding to @justaugustus to confirm.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2020
@justaugustus
Copy link
Member

Let's do this. Looks good!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, joakimr-axis, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 81b6980 into kubernetes:master Feb 14, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 14, 2020
@joakimr-axis joakimr-axis deleted the joakimr-axis_release.sh branch February 24, 2020 06:49
@BenTheElder BenTheElder mentioned this pull request Mar 2, 2020
Closed
@spiffxp spiffxp mentioned this pull request Mar 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@hwdef hwdef Awaiting requested review from hwdef

Assignees

@justaugustus justaugustus

@BenTheElder BenTheElder

@tpepper tpepper

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@joakimr-axis @k8s-ci-robot @BenTheElder @fejta @hwdef @justaugustus @tpepper