Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.16] No-op whitespace fix to CHANGELOG-1.16 to trigger a new 1.16 build #87333

Merged
merged 1 commit into from Jan 17, 2020
Merged

[1.16] No-op whitespace fix to CHANGELOG-1.16 to trigger a new 1.16 build #87333

merged 1 commit into from Jan 17, 2020

Conversation

justaugustus
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This is a minimal lint fix to trigger a new build version of Kubernetes 1.16
so that we can cut another release to fix the out of order tagging issue
described in k/k#86182.

Signed-off-by: Stephen Augustus saugustus@vmware.com

Which issue(s) this PR fixes:
Related #86182

Does this PR introduce a user-facing change?:

NONE

/assign @tpepper @neolit123 @liggitt
cc: @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jan 17, 2020
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 17, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 17, 2020
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 17, 2020
@justaugustus
Copy link
Member Author

/sig release
/area release-eng
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 17, 2020
@justaugustus
Copy link
Member Author

(because of course there should be test failures on a whitespace fix)
/retest

@justaugustus
Copy link
Member Author

/retest

@tpepper
Copy link
Member

tpepper commented Jan 17, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2020
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 17, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 17, 2020
@justaugustus
Copy link
Member Author

@kubernetes/ci-signal -- FYI on these failures.
/retest

@liggitt
Copy link
Member

liggitt commented Jan 17, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2020
@justaugustus
Copy link
Member Author

/retest

@justaugustus
[1.16] No-op whitespace fix to CHANGELOG-1.16 to trigger a new 1.16 b…
c3d8a1f 
…uild

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2020
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@justaugustus
Copy link
Member Author

(I added an empty commit and then squashed it into the previous to trigger the tests on a different SHA.)
Reapplying lgtm...

@justaugustus justaugustus added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 72c3016 into kubernetes:release-1.16 Jan 17, 2020
This was referenced Jan 18, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@neolit123 neolit123

@liggitt liggitt

@tpepper tpepper

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@justaugustus @tpepper @liggitt @k8s-ci-robot @neolit123