New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move 'path' package usage to 'path/filepath'. #87713
Conversation
In case of windows, the path package functions such as 'Dir' returns faulty directory path. For eg: 'path.Dir' on 'c:\var\lib\kubelet\pods' returns '.', where as the result should have been 'c:\var\lib\kubelet'. The filepath package returns the right values.
/retest |
3 similar comments
/retest |
/retest |
/retest |
/cc @andyzhangx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/priority important-soon
/sig windows
'path/filepath' supports windows.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, kkmsft The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind bug |
/retest Review the full test history for this PR. Silence the bot with an |
Move 'path' package usage to 'path/filepath' (repeat the #87713)
What type of PR is this?
/kind bug
What this PR does / why we need it:
In case of windows, the path package functions such as 'Dir' returns faulty directory path.
For eg: 'path.Dir' on 'c:\var\lib\kubelet\pods' returns '.', where as the result should
have been 'c:\var\lib\kubelet'. The filepath package returns the right values.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: