Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get azure disk lun timeout issue #88158

Merged
merged 1 commit into from Feb 14, 2020

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Feb 14, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR fixed the get azure disk lun timeout issue as suggested by @kosta709 thanks a lot!
Related PR already merged into azure disk CSI driver: kubernetes-sigs/azuredisk-csi-driver#285

regarding nodeserver.go - yes it polls every second, but if /dev/... is not there (findDiskByLun returns "") it returns fmt.Errorf("azureDisk - findDiskByLun(%v) failed within timeout", lun). and exits from wait.Poll
It causes to kubelet retry NodePublishVolume with exponensial backoff, and because /dev/disk/azure/... can appear 15-60s after first first call it can reach 2m timeout.
So I suggest to just return false, nil and let wait.Poll to retry instead of kubelet.

Which issue(s) this PR fixes:

Fixes #88159

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: get azure disk lun timeout issue

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/kind bug
/assign @feiskyer
/priority important-soon
/sig cloud-provider
/area provider/azure

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/azure Issues or PRs related to azure provider labels Feb 14, 2020
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 14, 2020
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 55ea3ac into kubernetes:master Feb 14, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 14, 2020
k8s-ci-robot added a commit that referenced this pull request Feb 21, 2020
…8158-upstream-release-1.15

Automated cherry pick of #88158: fix: get azure disk lun timeout issue
k8s-ci-robot added a commit that referenced this pull request Feb 21, 2020
…8158-upstream-release-1.17

Automated cherry pick of #88158: fix: get azure disk lun timeout issue
k8s-ci-robot added a commit that referenced this pull request Feb 21, 2020
…8158-upstream-release-1.16

Automated cherry pick of #88158: fix: get azure disk lun timeout issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get azure disk lun timeout issue
4 participants