Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use canonical URL for the krew project #88593

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Use canonical URL for the krew project #88593

merged 2 commits into from
Aug 27, 2020

Conversation

corneliusweig
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:
In official documentation, we should always use the canonical URL for kubernetes projects. I messed this up a bit in #88577 where I used

  • krew.dev which is just a privately owned redirect
  • github.com/kubernetes-sigs/krew which is not the official URL either

So I'd like to consistently change that to sigs.k8s.io/krew.

Which issue(s) this PR fixes:

Fixes kubernetes/kubectl#829

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 26, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @corneliusweig. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@corneliusweig
Copy link
Contributor Author

@pwittrock You were interested in the original PR #88577 in todays SIG-CLI. So here's already a follow-up fix. If you'd like any changes, this should be a good place :)

@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 26, 2020
@zhouya0
Copy link
Contributor

zhouya0 commented Feb 27, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2020
@sftim
Copy link
Contributor

sftim commented Feb 27, 2020

/sig docs

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 27, 2020
@corneliusweig
Copy link
Contributor Author

/hold
As @ahmetb suggested to move the installation instructions to another place.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2020
@corneliusweig corneliusweig mentioned this pull request Feb 28, 2020
Merged
ahmetb
ahmetb reviewed Feb 28, 2020
View reviewed changes
staging/src/k8s.io/kubectl/docs/book/pages/extending_kubectl/discovering_plugins.md Outdated
@@ -3,13 +3,13 @@
{% endpanel %}

{% panel style="info", title="TL;DR" %}
- [krew.dev](https://github.com/kubernetes-sigs/krew/#installation) is a kubernetes sub-project to discover and manage plugins
- [sigs.k8s.io/krew](https://sigs.k8s.io/krew/#installation) is a kubernetes sub-project to discover and manage plugins
Copy link
Member

@ahmetb ahmetb Feb 28, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an outstanding PR that'll render this broken.

https://krew.sigs.k8s.io/docs/user-guide/setup/install/ might be better for all these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've adapted the link so that it points to our new project site.

@corneliusweig
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2020
@ahmetb
Copy link
Member

ahmetb commented Mar 1, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2020
@corneliusweig
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind

@brianpursley
Copy link
Member

/lgtm

@brianpursley brianpursley removed their assignment Mar 24, 2020
@brianpursley
Copy link
Member

/kind documentation
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 29, 2020
soltysh
soltysh approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@soltysh
Copy link
Contributor

soltysh commented Jul 22, 2020

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corneliusweig, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2020
@corneliusweig
Copy link
Contributor Author

Thanks for picking this up!

@corneliusweig
Copy link
Contributor Author

/test pull-kubernetes-conformance-kind-ga-only-parallel

@ahmetb
Copy link
Member

ahmetb commented Aug 16, 2020

Someone needs to assign a milestone apparently.

@k8s-ci-robot k8s-ci-robot merged commit 8ea535c into kubernetes:master Aug 27, 2020
@corneliusweig corneliusweig deleted the w/use-canonical-url-for-krew branch August 29, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmetb ahmetb ahmetb left review comments

@soltysh soltysh soltysh approved these changes

@brianpursley brianpursley brianpursley approved these changes

@shiywang shiywang Awaiting requested review from shiywang

Assignees

@ahmetb ahmetb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

Kubectl Book: Use canonical URL for krew
8 participants
@corneliusweig @k8s-ci-robot @zhouya0 @sftim @ahmetb @brianpursley @soltysh @justaugustus