Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --export flag from kubectl get command. #88649

Merged
merged 1 commit into from Jun 18, 2020
Merged

Remove --export flag from kubectl get command. #88649

merged 1 commit into from Jun 18, 2020

Conversation

oke-py
Copy link
Contributor

@oke-py oke-py commented Feb 28, 2020

What type of PR is this?

/kind deprecation

What this PR does / why we need it:

This PR removes --export flag from kubectl get command.
This flag is planned to be removed in v1.18.

git grep '\-\-export' CHANGELOG
CHANGELOG/CHANGELOG-1.14.md:  - The `--export` flag for the `kubectl get` command is deprecated and will be removed in v1.18. ([#73787](https:
CHANGELOG/CHANGELOG-1.14.md:* Deprecate --export flag from kubectl get command. ([#73787](https://github.com/kubernetes/kubernetes/pull/73787)
CHANGELOG/CHANGELOG-1.15.md:  - The `--export` flag for the `kubectl get` command, deprecated since v1.14, will be removed in v1.18.
CHANGELOG/CHANGELOG-1.16.md:  - The `--export` flag for the `kubectl get` command, deprecated since v1.14, will be removed in v1.18.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Remove --export flag from kubectl get command.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl area/test sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 28, 2020
@zhouya0
Copy link
Contributor

zhouya0 commented Feb 28, 2020

/lgtm
Thanks.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2020
@oke-py
Copy link
Contributor Author

oke-py commented Feb 28, 2020

/test pull-kubernetes-e2e-kind

@oke-py
Copy link
Contributor Author

oke-py commented Feb 28, 2020

/assign @deads2k

soltysh
soltysh approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this deprecation raised a lot of concerns, I'd prefer we keep it for one more release. Send an announcement to k8s-dev and sig-cli mailing list and only then we will deprecate this rather than shortly before code freeze.
/hold
/milestone v1.19

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 4, 2020
@soltysh
Copy link
Contributor

soltysh commented Mar 4, 2020

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 4, 2020
@oke-py
Copy link
Contributor Author

oke-py commented Mar 4, 2020

Thanks for your reply. I got it.

@bai
Copy link

bai commented May 29, 2020

👋 Hello from Bug Triage team! This PR has not been updated for a while, so I'd like to check its status. The code freeze is starting June 25th (about 4 weeks from now) and while there is still plenty of time, we want to ensure that each PR has a chance to be merged on time.

As the PR is tagged for 1.19, is it still planned for this release?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2020
@oke-py
Copy link
Contributor Author

oke-py commented May 30, 2020

@bai I'm waiting for sig-cli decision on whether --export flag will be removed in v1.19.
@soltysh Have you decided it?

If yes, I'll rebase this branch to resolve conflicts.

@soltysh
Copy link
Contributor

soltysh commented Jun 5, 2020 •
edited

@oke-py yes, this is good to go, pls rebase and ping me on slack for a tag.

@oke-py
Copy link
Contributor Author

oke-py commented Jun 17, 2020

/retest

soltysh
soltysh approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oke-py, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@dims
Copy link
Member

dims commented Jun 17, 2020

/hold Temporary hold to get prow/tide to get back on its feet. Feel free to remove hold in a few hours.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2020
@dims
Copy link
Member

dims commented Jun 17, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2020
@oke-py
Copy link
Contributor Author

oke-py commented Jun 18, 2020

/retest

2 similar comments
@oke-py
Copy link
Contributor Author

oke-py commented Jun 18, 2020

/retest

@oke-py
Copy link
Contributor Author

oke-py commented Jun 18, 2020

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@oke-py
Copy link
Contributor Author

oke-py commented Jun 18, 2020

/retest

2 similar comments
@dims
Copy link
Member

dims commented Jun 18, 2020

/retest

@dims
Copy link
Member

dims commented Jun 18, 2020

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 1faf097 into kubernetes:master Jun 18, 2020
@oke-py oke-py deleted the remove-deprecated-export branch June 18, 2020 22:23
@github-actions github-actions bot mentioned this pull request Jun 23, 2020
Open
@Kyrluckechuck Kyrluckechuck mentioned this pull request Aug 31, 2020
Merged
@ssadok
Copy link

ssadok commented Nov 5, 2020

Whiy !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

@pacoxu pacoxu mentioned this pull request Jan 22, 2021
Closed
@deads2k
Copy link
Contributor

deads2k commented Jan 22, 2021

This went through multiple discussions, culminating in #73783 . Basically there is no reasonable way for an export to be handled server-side. Because of this, it makes more sense to remove the entire option. See the deprecating PR and other discussions.

#73783, #24855, #49497

@deads2k deads2k mentioned this pull request Jan 22, 2021
Merged
@soltysh soltysh mentioned this pull request Jan 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@eparis eparis Awaiting requested review from eparis

Assignees

@soltysh soltysh

@deads2k deads2k

@zhouya0 zhouya0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@oke-py @zhouya0 @soltysh @bai @k8s-ci-robot @fejta-bot @dims @ssadok @deads2k