Mark PVCDataSource featuregate as GA #88686

j-griffith · 2020-02-29T05:30:35Z

/kind feature

What this PR does / why we need it:

Marks VolumePVCDataSource as GA for 1.18

Which issue(s) this PR fixes:

Special notes for your reviewer:

VolumePVCDataSource moves to GA in 1.18 release

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

https://github.com/kubernetes/website/pull/19318

jsafrane

Please remove feature gate evaluation in

kubernetes/pkg/api/persistentvolumeclaim/util.go

Line 67 in fdb2cb4

if utilfeature.DefaultFeatureGate.Enabled(features.VolumePVCDataSource) &&

- it's always true now.

pkg/api/persistentvolumeclaim/util_test.go

jsafrane · 2020-03-02T18:52:28Z

/lgtm
Failed e2e-gce-alpha-features is not related to this PR and is being fixed in #88727

jsafrane · 2020-03-02T19:02:14Z

/kind api-review
for changes in validation (i.e. removal of feature checks)

k8s-ci-robot · 2020-03-02T19:02:16Z

@jsafrane: The label(s) kind/api-review cannot be applied, because the repository doesn't have them

In response to this:

/kind api-review
for changes in validation (i.e. removal of feature checks)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jsafrane · 2020-03-02T19:02:50Z

/label api-review
for changes in validation (i.e. removal of feature checks)

smarterclayton · 2020-03-02T20:23:08Z

/assign @smarterclayton

smarterclayton · 2020-03-02T20:26:05Z

Does the godoc on DataSource need to be updated? I see:

	// This field requires the VolumeSnapshotDataSource alpha feature gate to be
	// enabled and currently VolumeSnapshot is the only supported data source.
	// If the provisioner can support VolumeSnapshot data source, it will create
	// a new volume and data will be restored to the volume at the same time.
	// If the provisioner does not support VolumeSnapshot data source, volume will
	// not be created and the failure will be reported as an event.
	// In the future, we plan to support more data source types and the behavior
	// of the provisioner may change.
	// +optional
	DataSource *TypedLocalObjectReference `json:"dataSource,omitempty" protobuf:"bytes,7,opt,name=dataSource"`

and I would expect it to be updated.

j-griffith · 2020-03-04T02:29:31Z

/test pull-kubernetes-e2e-gci-gce-autoscaling

j-griffith · 2020-03-04T04:22:17Z

/test pull-kubernetes-e2e-gci-gce-autoscaling

j-griffith · 2020-03-04T04:23:03Z

/test pull-kubernetes-verify

jsafrane · 2020-03-04T09:04:29Z

almost there, but generated doc is out of sync:

Generated swagger type documentation is out of date:
--- /home/prow/go/src/k8s.io/kubernetes/./staging/src/k8s.io/api/core/v1/types_swagger_doc_generated.go	2020-03-04 04:26:30.111495230 +0000
+++ /tmp/swagger-docs.IZkoOW/src/k8s.io/kubernetes/./staging/src/k8s.io/api/core/v1/types_swagger_doc_generated.go	2020-03-04 05:09:42.551694271 +0000
@@ -1300,7 +1300,7 @@ var map_PersistentVolumeClaimSpec = map[
 	"resources":        "Resources represents the minimum resources the volume should have. More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes#resources",
 	"volumeName":       "VolumeName is the binding reference to the PersistentVolume backing this claim.",
 	"storageClassName": "Name of the StorageClass required by the claim. More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes#class-1",
-	"volumeMode":       "volumeMode defines what type of volume is required by the claim. Value of Filesystem is implied when not included in claim spec. This is a beta feature.",
+	"volumeMode":       "volumeMode defines what type of volume is required by the claim. Value of Filesystem is implied when not included in claim spec.",

I think hack/update-generated-swagger-docs.sh is the right tool to fix this.

j-griffith · 2020-03-04T14:09:02Z

almost there, but generated doc is out of sync:

Generated swagger type documentation is out of date:
--- /home/prow/go/src/k8s.io/kubernetes/./staging/src/k8s.io/api/core/v1/types_swagger_doc_generated.go	2020-03-04 04:26:30.111495230 +0000
+++ /tmp/swagger-docs.IZkoOW/src/k8s.io/kubernetes/./staging/src/k8s.io/api/core/v1/types_swagger_doc_generated.go	2020-03-04 05:09:42.551694271 +0000
@@ -1300,7 +1300,7 @@ var map_PersistentVolumeClaimSpec = map[
 	"resources":        "Resources represents the minimum resources the volume should have. More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes#resources",
 	"volumeName":       "VolumeName is the binding reference to the PersistentVolume backing this claim.",
 	"storageClassName": "Name of the StorageClass required by the claim. More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes#class-1",
-	"volumeMode":       "volumeMode defines what type of volume is required by the claim. Value of Filesystem is implied when not included in claim spec. This is a beta feature.",
+	"volumeMode":       "volumeMode defines what type of volume is required by the claim. Value of Filesystem is implied when not included in claim spec.",

I think hack/update-generated-swagger-docs.sh is the right tool to fix this.

It is, and tha'ts what I used (through make update anyway), then the rebase happened with a conflict in the proto file, I should've run it again.

j-griffith · 2020-03-04T15:09:29Z

/test pull-kubernetes-e2e-kind

j-griffith · 2020-03-04T16:14:10Z

/retest

pkg/api/persistentvolumeclaim/util_test.go

smarterclayton · 2020-03-04T17:32:45Z

staging/src/k8s.io/api/core/v1/generated.proto

-  // If the provisioner does not support VolumeSnapshot data source, volume will
+  // This field can be used to specify either:
+  // * An existing VolumeSnapshot object (snapshot.storage.k8s.io/VolumeSnapshot - Beta)
+  // * An existing PVC (PersistentVolumeClaim - GA)


You shouldn't have to say PVC is GA (since anything not called out as alpha or beta is implicitly GA). Remove the - GA part (but keep - Beta on snapshot).

smarterclayton · 2020-03-04T17:33:19Z

One more tweak and I will approve this.

smarterclayton · 2020-03-04T17:33:57Z

Also, the "Fixes" bug in the PR description looks wrong, should that be pointing to an enhancement?

j-griffith · 2020-03-04T17:42:49Z

Also, the "Fixes" bug in the PR description looks wrong, should that be pointing to an enhancement?

Opened an issue in the k8s project and linked it, thanks!

Updates the VolumePVCDataSource featuregate (cloning) to GA for the 1.18 k8s release.

smarterclayton · 2020-03-04T18:12:32Z

/approve

k8s-ci-robot · 2020-03-04T18:14:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: j-griffith, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~api/OWNERS~~ [smarterclayton]
~~pkg/api/OWNERS~~ [smarterclayton]
~~pkg/apis/core/OWNERS~~ [smarterclayton]
~~pkg/features/OWNERS~~ [smarterclayton]
~~staging/src/k8s.io/api/OWNERS~~ [smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jsafrane · 2020-03-04T18:16:28Z

/lgtm

j-griffith · 2020-03-04T19:07:48Z

/test pull-kubernetes-e2e-gci-gce-autoscaling
/test pull-kubernetes-e2e-kind

saad-ali · 2020-03-04T19:10:59Z

/milestone v1.18

saad-ali · 2020-03-04T19:12:38Z

/priority important-soon

k8s-ci-robot · 2020-03-04T19:12:40Z

@saad-ali: The label(s) priority/ cannot be applied, because the repository doesn't have them

In response to this:

/priority important-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2020-03-04T19:32:17Z

@j-griffith: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-kubernetes-e2e-gci-gce-autoscaling	`9044fbf`	link	`/test pull-kubernetes-e2e-gci-gce-autoscaling`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot requested review from smarterclayton and thockin February 29, 2020 05:33

j-griffith force-pushed the upgrade_cloning_to_ga branch from 4a51442 to 9ca2e97 Compare February 29, 2020 15:42

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 29, 2020

jsafrane reviewed Mar 2, 2020

View reviewed changes

pkg/api/persistentvolumeclaim/util_test.go Show resolved Hide resolved

j-griffith force-pushed the upgrade_cloning_to_ga branch from 9ca2e97 to 09fb34c Compare March 2, 2020 16:37

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 2, 2020

k8s-ci-robot assigned jsafrane Mar 2, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2020

k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Mar 2, 2020

k8s-ci-robot assigned smarterclayton Mar 2, 2020

j-griffith force-pushed the upgrade_cloning_to_ga branch from 09fb34c to 5dfa03e Compare March 2, 2020 21:26

j-griffith force-pushed the upgrade_cloning_to_ga branch from dcc6b8e to 27e145b Compare March 4, 2020 14:21

jsafrane reviewed Mar 4, 2020

View reviewed changes

pkg/api/persistentvolumeclaim/util_test.go Show resolved Hide resolved

j-griffith force-pushed the upgrade_cloning_to_ga branch from 27e145b to a2a91e9 Compare March 4, 2020 16:45

smarterclayton reviewed Mar 4, 2020

View reviewed changes

Update VolumePVCDatasource to GA for 1.18

9044fbf

Updates the VolumePVCDataSource featuregate (cloning) to GA for the 1.18 k8s release.

j-griffith force-pushed the upgrade_cloning_to_ga branch from a2a91e9 to 9044fbf Compare March 4, 2020 17:48

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2020

k8s-ci-robot added this to the v1.18 milestone Mar 4, 2020

k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 4, 2020

k8s-ci-robot merged commit e865c0b into kubernetes:master Mar 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mark PVCDataSource featuregate as GA #88686

Mark PVCDataSource featuregate as GA #88686

j-griffith commented Feb 29, 2020 •

edited

jsafrane left a comment

jsafrane commented Mar 2, 2020

jsafrane commented Mar 2, 2020

k8s-ci-robot commented Mar 2, 2020

jsafrane commented Mar 2, 2020

smarterclayton commented Mar 2, 2020

smarterclayton commented Mar 2, 2020

j-griffith commented Mar 4, 2020

j-griffith commented Mar 4, 2020

j-griffith commented Mar 4, 2020

jsafrane commented Mar 4, 2020

j-griffith commented Mar 4, 2020 •

edited

j-griffith commented Mar 4, 2020

j-griffith commented Mar 4, 2020

smarterclayton Mar 4, 2020

smarterclayton commented Mar 4, 2020

smarterclayton commented Mar 4, 2020

j-griffith commented Mar 4, 2020 •

edited

smarterclayton commented Mar 4, 2020

k8s-ci-robot commented Mar 4, 2020

jsafrane commented Mar 4, 2020

j-griffith commented Mar 4, 2020

saad-ali commented Mar 4, 2020

saad-ali commented Mar 4, 2020

k8s-ci-robot commented Mar 4, 2020

k8s-ci-robot commented Mar 4, 2020 •

edited

Mark PVCDataSource featuregate as GA #88686

Mark PVCDataSource featuregate as GA #88686

Conversation

j-griffith commented Feb 29, 2020 • edited

jsafrane left a comment

Choose a reason for hiding this comment

jsafrane commented Mar 2, 2020

jsafrane commented Mar 2, 2020

k8s-ci-robot commented Mar 2, 2020

jsafrane commented Mar 2, 2020

smarterclayton commented Mar 2, 2020

smarterclayton commented Mar 2, 2020

j-griffith commented Mar 4, 2020

j-griffith commented Mar 4, 2020

j-griffith commented Mar 4, 2020

jsafrane commented Mar 4, 2020

j-griffith commented Mar 4, 2020 • edited

j-griffith commented Mar 4, 2020

j-griffith commented Mar 4, 2020

smarterclayton Mar 4, 2020

Choose a reason for hiding this comment

smarterclayton commented Mar 4, 2020

smarterclayton commented Mar 4, 2020

j-griffith commented Mar 4, 2020 • edited

smarterclayton commented Mar 4, 2020

k8s-ci-robot commented Mar 4, 2020

jsafrane commented Mar 4, 2020

j-griffith commented Mar 4, 2020

saad-ali commented Mar 4, 2020

saad-ali commented Mar 4, 2020

k8s-ci-robot commented Mar 4, 2020

k8s-ci-robot commented Mar 4, 2020 • edited

j-griffith commented Feb 29, 2020 •

edited

j-griffith commented Mar 4, 2020 •

edited

j-griffith commented Mar 4, 2020 •

edited

k8s-ci-robot commented Mar 4, 2020 •

edited