Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingress: allow wildcard hosts in IngressRule #88858

Merged
merged 1 commit into from Mar 5, 2020
Merged

ingress: allow wildcard hosts in IngressRule #88858

merged 1 commit into from Mar 5, 2020

Conversation

cmluciano
Copy link

Signed-off-by: Christopher M. Luciano cmluciano@us.ibm.com

What type of PR is this?
/kind api-change

What this PR does / why we need it:
This PR tests that wildcard hosts are accepted and updates the types documentation to explicitly state the support of wildcard hosts

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

ingress: allow wildcard hosts in IngressRule

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Ingress KEP

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 5, 2020
@cmluciano
Copy link
Author

/assign @robscott @liggitt

This should be the final PR for the planned 1.18 Ingress changes

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 5, 2020
liggitt
liggitt reviewed Mar 5, 2020
View reviewed changes
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one doc nit, lgtm otherwise

pkg/apis/networking/types.go Show resolved Hide resolved
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt liggitt added this to the v1.18 milestone Mar 5, 2020
@liggitt liggitt added this to API review completed, 1.18 in API Reviews Mar 5, 2020
@liggitt
Copy link
Member

liggitt commented Mar 5, 2020

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 5, 2020
ingress: allow wildcard hosts in IngressRule
e931e30 
Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
@cmluciano cmluciano requested a review from liggitt March 5, 2020 18:45
@liggitt
Copy link
Member

liggitt commented Mar 5, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cmluciano, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8508875 into kubernetes:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@danwinship danwinship Awaiting requested review from danwinship

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@robscott robscott

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
API Reviews
Status: API review completed, 1.18
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cmluciano @fejta-bot @liggitt @k8s-ci-robot @robscott