Add tests for DeleteOptions apiserver deserialization

[mikedanese]

Unfortunately, kube-apiserver accepts almost anything right now. It should continue to do so or an unknown number of clients will break due to a later seemingly benign "bug fix".

[lavalamp]

cc @liggitt

[mikedanese]

To add a bit more detail, we unpack DeleteOptions here with a default GVK:

kubernetes/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/delete.go

Lines 89 to 92 in 0ec85a1

	// For backwards compatibility, we need to allow existing clients to submit per group DeleteOptions
	// It is also allowed to pass a body with meta.k8s.io/v1.DeleteOptions
	defaultGVK := scope.MetaGroupVersion.WithKind("DeleteOptions")
	obj, _, err := metainternalversionscheme.Codecs.DecoderToVersion(s.Serializer, defaultGVK.GroupVersion()).Decode(body, &defaultGVK, options)

So kind and apiversion are defaulted if not provided. But we only validate that Kind is correct in:

kubernetes/staging/src/k8s.io/apimachinery/pkg/runtime/codec.go

Lines 83 to 98 in 0ec85a1

	// UseOrCreateObject returns obj if the canonical ObjectKind returned by the provided typer matches gvk, or
	// invokes the ObjectCreator to instantiate a new gvk. Returns an error if the typer cannot find the object.
	func UseOrCreateObject(t ObjectTyper, c ObjectCreater, gvk schema.GroupVersionKind, obj Object) (Object, error) {
	if obj != nil {
	kinds, _, err := t.ObjectKinds(obj)
	if err != nil {
	return nil, err
	}
	for _, kind := range kinds {
	if gvk == kind {
	return obj, nil
	}
	}
	}
	return c.New(gvk)
	}

We'll accept:

{}
{"propagationPolicy":"Background"}
{"kind":"DeleteOptions","propagationPolicy":"Background"}
{"apiVersion":"meta.k8s.io/v1"}
{"apiVersion":"wat"}

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lavalamp]

/reopen
/lifecycle frozen

[k8s-ci-robot]

@lavalamp: Reopened this issue.

In response to this:

/reopen
/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.