-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #88911: /readyz should start returning failure on shutdown initiation #88954
Automated cherry pick of #88911: /readyz should start returning failure on shutdown initiation #88954
Conversation
Currently, /readyz starts reporting failure after ShutdownDelayDuration elapses. We expect /readyz to start returning failure as soon as shutdown is initiated. This gives the load balancer a window defined by ShutdownDelayDuration to detect that /readyz is red and stop sending traffic to this server.
Hi @tkashem. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @sttts |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest |
1 similar comment
/retest |
Cherry pick of #88911 on release-1.16.
#88911: /readyz should start returning failure on shutdown initiation
For details on the cherry pick process, see the cherry pick requests page.