Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make filteredZones order predictable by using List() instead of UnsortedList() #88987

Merged
merged 2 commits into from Mar 18, 2020
Merged

make filteredZones order predictable by using List() instead of UnsortedList() #88987

merged 2 commits into from Mar 18, 2020

Conversation

jiahuif
Copy link
Member

@jiahuif jiahuif commented Mar 9, 2020 •
edited

What type of PR is this?
/kind flake

What this PR does / why we need it:
This PR fixes a flake in TestTopologyTranslation due to the order of filteredZones being unpredictable. This makes object comparison easier for the users of this resource.

I did not find any other places where unsorted lists were returned to the caller. Please comment if you find any.

Which issue(s) this PR fixes:

Background: #87163 should fix it.

Special notes for your reviewer:
Please take a look at #87163 for background.

Does this PR introduce a user-facing change?:

a PV set from in-tree source will have ordered requirement values in NodeAffinity when converted to CSIPersistentVolumeSource

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig storage

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/flake Categorizes issue or PR as related to a flaky test. sig/storage Categorizes an issue or PR as relevant to SIG Storage. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 9, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @jiahuif. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 9, 2020
@jiahuif
Copy link
Member Author

jiahuif commented Mar 9, 2020

/assign @davidz627

@jiahuif
Copy link
Member Author

jiahuif commented Mar 9, 2020

Or, I can change the test case. Please comment on which way to choose.

@lavalamp
Copy link
Member

This looks correct. Please add a test.

@liggitt liggitt added this to the v1.18 milestone Mar 11, 2020
@liggitt
Copy link
Member

liggitt commented Mar 11, 2020

/ok-to-test
/priority important-soon
/kind bug

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/bug Categorizes issue or PR as related to a bug. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 11, 2020
@liggitt
Copy link
Member

liggitt commented Mar 13, 2020

/retest

@liggitt
Copy link
Member

liggitt commented Mar 13, 2020

Please add a test so this can be merged

@markjacksonfishing
Copy link

@jiahuif want to see how this is going and if we are going to make v1.18?

@cpanato
Copy link
Member

cpanato commented Mar 17, 2020

ping @liggitt are we moving forward with this one? or we remove the milestone?

@liggitt
Copy link
Member

liggitt commented Mar 17, 2020

It should be in 1.18. Please add a unit test exposing the previous bug

@jiahuif
Copy link
Member Author

jiahuif commented Mar 17, 2020

Sorry, will do right now.

@k8s-ci-robot k8s-ci-robot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 17, 2020
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 17, 2020
@jiahuif
make filteredZones order predictable
4c3d40b 
by using List() instead of UnsortedList()
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 17, 2020
@jiahuif
Copy link
Member Author

jiahuif commented Mar 17, 2020

/retest

@liggitt
Copy link
Member

liggitt commented Mar 17, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2020
@liggitt
Copy link
Member

liggitt commented Mar 17, 2020

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiahuif, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2020
@jiahuif
Copy link
Member Author

jiahuif commented Mar 17, 2020

/retest

1 similar comment
@jiahuif
Copy link
Member Author

jiahuif commented Mar 17, 2020

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@jiahuif
Copy link
Member Author

jiahuif commented Mar 18, 2020

/retest

@liggitt
Copy link
Member

liggitt commented Mar 18, 2020

master has reopened so this will need to be picked to the release-1.18 branch as well

@k8s-ci-robot k8s-ci-robot merged commit 42972f2 into kubernetes:master Mar 18, 2020
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.18, v1.19 Mar 18, 2020
@jiahuif jiahuif mentioned this pull request Mar 18, 2020
Merged
k8s-ci-robot added a commit that referenced this pull request Mar 19, 2020
@k8s-ci-robot
Merge pull request #89238 from jiahuif/automated-cherry-pick-of-#8898…
0ad20f5 
…7-upstream-release-1.18

Automated cherry pick of #88987: make filteredZones order predictable
@jiahuif jiahuif mentioned this pull request Mar 19, 2020
Closed
@jiahuif jiahuif deleted the patch-1 branch March 19, 2020 22:04
@jiahuif jiahuif mentioned this pull request May 11, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@ddebroy ddebroy Awaiting requested review from ddebroy

Assignees

@liggitt liggitt

@davidz627 davidz627

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jiahuif @k8s-ci-robot @lavalamp @liggitt @markjacksonfishing @cpanato @fejta-bot @davidz627