Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration of re-usable package from pkg/kubelet/cm/cpumanager to pkg/kubelet/cm #89053

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

bg-chun
Copy link
Member

@bg-chun bg-chun commented Mar 11, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

containerMap is used in CPU Manager to store all containers information in the node.
containerMap provides a mapping from (pod, container) -> containerID for all containers a pod
It is reusable in another component in pkg/kubelet/cm which needs to track changes of all containers in the node.

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

simple migration of package

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Nope

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 11, 2020
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 11, 2020
@bg-chun
Copy link
Member Author

bg-chun commented Mar 11, 2020

/ok-to-test
/sig node

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 11, 2020
@bg-chun
Copy link
Member Author

bg-chun commented Mar 11, 2020

/assign @dchen1107
/assign @derekwaynecarr

…ermap for reusing

containerMap is used in CPU Manager to store all containers information in the node.
containerMap provides a mapping from (pod, container) -> containerID for all containers a pod
It is reusable in another component in pkg/kubelet/cm which needs to track changes of all containers in the node.

Signed-off-by: Byonggon Chun <bg.chun@samsung.com>
@klueska
Copy link
Contributor

klueska commented Mar 13, 2020

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2020
@bg-chun bg-chun closed this Mar 13, 2020
@bg-chun bg-chun reopened this Mar 13, 2020
@bg-chun bg-chun closed this Mar 26, 2020
@bg-chun bg-chun reopened this Mar 26, 2020
@derekwaynecarr
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bg-chun, derekwaynecarr, klueska

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4488fd4 into kubernetes:master Mar 26, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 26, 2020
cynepco3hahue pushed a commit to cynepco3hahue/origin that referenced this pull request Jun 15, 2020
…pumanager to pkg/kubelet/cm

ref: kubernetes/kubernetes#89053

Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
cynepco3hahue pushed a commit to cynepco3hahue/origin that referenced this pull request Jun 15, 2020
…pumanager to pkg/kubelet/cm

ref: kubernetes/kubernetes#89053

Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/origin that referenced this pull request Jul 11, 2020
…pumanager to pkg/kubelet/cm

ref: kubernetes/kubernetes#89053

Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Jul 11, 2020
…pumanager to pkg/kubelet/cm

ref: kubernetes#89053

Signed-off-by: Artyom Lukianov <alukiano@redhat.com>

Origin-commit: f0ed0cc65a4eab6e99369f610955d275ec44a1a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants