Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unbound variable error in gce/configure.sh #89097

Merged
merged 1 commit into from Mar 13, 2020
Merged

Fix unbound variable error in gce/configure.sh #89097

merged 1 commit into from Mar 13, 2020

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Mar 12, 2020 •
edited

Error:

kubernetes/bin/configure.sh: line 501: UBUNTU_INSTALL_RUNC_VERSION: unbound variable

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix the bug.

NONE

/priority important-soon

@jpbetz
Fix unbound variable error in gce/configure.sh
23c358d 
Looks like UBUNTU_INSTALL_RUNC_VERSION should be optional here.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/release-eng Issues or PRs related to the Release Engineering subproject sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 12, 2020
@jpbetz
Copy link
Contributor Author

jpbetz commented Mar 12, 2020

/milestone 1.18

@k8s-ci-robot
Copy link
Contributor

@jpbetz: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jpbetz referenced this pull request Mar 12, 2020
@dims
Ability to override versions of containerd/runc
da024f9
@jpbetz
Copy link
Contributor Author

jpbetz commented Mar 12, 2020

/assign @dims

@jpbetz
Copy link
Contributor Author

jpbetz commented Mar 12, 2020

cc @liggitt

@liggitt
Copy link
Member

liggitt commented Mar 12, 2020

/milestone v1.18

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 12, 2020
@jpbetz
Copy link
Contributor Author

jpbetz commented Mar 13, 2020

/test pull-kubernetes-e2e-kind-ipv6

@liggitt
Copy link
Member

liggitt commented Mar 13, 2020

/lgtm
/approve

Clarify the error seen this is fixing in the description

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2020
@dims
Copy link
Member

dims commented Mar 13, 2020

whoops. thanks @jpbetz

@liggitt
Copy link
Member

liggitt commented Mar 13, 2020

/retest

@jpbetz
Copy link
Contributor Author

jpbetz commented Mar 13, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 3524a5a into kubernetes:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mml mml Awaiting requested review from mml

@roycaihw roycaihw Awaiting requested review from roycaihw

Assignees

@dims dims

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jpbetz @k8s-ci-robot @liggitt @dims