e2e wait until controller manager pod ready

[aojea]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature

/kind flake

What this PR does / why we need it:

It turns out that the method used to wait for the controller manager pod fails if the pod doesn't exist

kubernetes/test/e2e/framework/pod/resource.go

Lines 148 to 153 in b290e0b

	func podRunning(c clientset.Interface, podName, namespace string) wait.ConditionFunc {
	return func() (bool, error) {
	pod, err := c.CoreV1().Pods(namespace).Get(context.TODO(), podName, metav1.GetOptions{})
	if err != nil {
	return false, err
	}

we switch to WaitForPodsReady for waiting for the controller manager pod to be available

kubernetes/test/e2e/framework/pod/wait.go

Lines 535 to 550 in b290e0b

	func WaitForPodsReady(c clientset.Interface, ns, name string, minReadySeconds int) error {
	label := labels.SelectorFromSet(labels.Set(map[string]string{"name": name}))
	options := metav1.ListOptions{LabelSelector: label.String()}
	return wait.Poll(poll, 5*time.Minute, func() (bool, error) {
	pods, err := c.CoreV1().Pods(ns).List(context.TODO(), options)
	if err != nil {
	return false, nil
	}
	for _, pod := range pods.Items {
	if !podutil.IsPodAvailable(&pod, int32(minReadySeconds), metav1.Now()) {
	return false, nil
	}
	}
	return true, nil
	})
	}

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[aojea]

/assign @liggitt
let's see if this is the last one of this saga 🤞

[aojea]

just unrelated question to the PR, but shouldn't we wait for the controller-manager pod to be ready before starting the tests?

it should be here

kubernetes/test/e2e/e2e.go

Lines 71 to 79 in 5708511

	var _ = ginkgo.SynchronizedBeforeSuite(func() []byte {
	// Reference common test to make the import valid.
	commontest.CurrentSuite = commontest.E2E
	setupSuite()
	return nil
	}, func(data []byte) {
	// Run on all Ginkgo nodes
	setupSuitePerGinkgoNode()
	})

[SataQiu]

/lgtm

[liggitt]

/lgtm
/approve
/retest
/milestone v1.18

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/e2e/framework/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aojea]

/retest

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.