Fix mountOptions in iSCSI and FC volume plugins #89172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not mount volumes in WaitForAttach(), mount them in MountDevice() instead. They will get proper mount options this way.
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
sig/storage
jsafrane
force-pushed
the
fix-mount-opts
branch
from
ab63f85
to
3ac39a2
Compare
|
/retest |
gnufied
reviewed
Mar 24, 2020
|
/assign |
gnufied
reviewed
Mar 24, 2020
pkg/volume/iscsi/iscsi_util.go
Outdated
| if err = util.persistISCSI(b); err != nil { | ||
| // Return transient error so kubelet calls Unmount / Unmap when the pod | ||
| // is deleted. | ||
| return "", types.NewTransientOperationFailure(err.Error()) |
There was a problem hiding this comment.
Also may be some tests for that?
There was a problem hiding this comment.
There is no unit test for whole AttachDisk() function and adding one extends scope of this PR in order of magnitude.
jsafrane
force-pushed
the
fix-mount-opts
branch
2 times, most recently
from
5f33ad4
to
5f7c254
Compare
|
/retest |
jsafrane
force-pushed
the
fix-mount-opts
branch
from
5f7c254
to
1a900a7
Compare
gnufied
reviewed
Mar 26, 2020
pkg/volume/iscsi/iscsi_util.go
Outdated
| return globalPDPathOperation(b)(b, devicePath, util) | ||
|
|
||
| if err = util.persistISCSI(b); err != nil { | ||
| // Return transient error so kubelet calls Unmount / Unmap when the pod |
Do not mount volumes in WaitForAttach(), mount them in MountDevice() instead. They will get proper mount options this way.
jsafrane
force-pushed
the
fix-mount-opts
branch
from
1a900a7
to
58129fd
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest Review the full test history for this PR. Silence the bot with an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Move mounting of volumes from
WaitForAttach()toMountDevice. This way, mountOptions are correctly applied.Fixes #89171
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: