e2e/storage: check result of WaitForPersistentVolumeDeleted #88118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
This is WIP because it should fail due to the bug in the CSI mock driver. A new csi-test release is needed. |
k8s-ci-robot
added
area/test
sig/storage
k8s-ci-robot
added
the
needs-rebase
pohly
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
pohly
force-pushed
the
wait-for-persistent-volume-deleted-error
branch
from
45a73b3
to
ac3f381
Compare
k8s-ci-robot
added
size/S
When deleting fails, the tests should be considered as failed, too. Ignoring the error caused a wrong return code in the CSI mock driver to go unnoticed (see kubernetes-csi/csi-test#250). The v3.1.0 release of the CSI mock driver fixes that.
pohly
force-pushed
the
wait-for-persistent-volume-deleted-error
branch
from
ac3f381
to
c9004e7
Compare
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
When deleting fails, the tests should be considered as failed,
too. Ignoring the error caused a wrong return code in the CSI mock
driver to go unnoticed (see
kubernetes-csi/csi-test#250).
Does this PR introduce a user-facing change?: