Add check for volume zone GA labels

[notpad]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Volume zone labels has been promoted to GA in #81431, we need to use the GA labels

Which issue(s) this PR fixes:

Fixes #89261

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig scheduling
/assign @ahg-g

[notpad]

/priority important-soon

[ahg-g]

few nits related to test names.

[ahg-g]

thanks, please squash

[notpad]

squashed

[ahg-g]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, notpad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS [ahg-g]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[liggitt]

@msau42 I thought the intent was for the scheduler not to special-case zone/region labels... were you expecting this PR?

[ahg-g]

@liggitt should we expect in the future that the old variables (e.g., LabelZoneRegion) will point to the GA labels?

[liggitt]

No, we don't redefine constants. Nodes report the beta and GA labels for now, and a controller ensures the beta and GA labels match. The controller will switch to treating the GA labels as the source of truth in #88493 (in ~1.21).

[ahg-g]

so the schedule should start checking the stable labels at some point, is there an issue doing it now?

[liggitt]

if special treatment of the zone/region labels is still required, switching to use the GA labels is ok to do now

[liggitt]

I thought the goal was for the scheduler to not treat zone/region labels differently than any other topology labels

[msau42]

The intent is to delete this volumezone predicate once csimigration is GA for all the cloud plugins that use this label. So we decided not to convert volumes to use the new ga labels and block removal of the beta labels on csimigration

[msau42]

(going forward we only use PV.NodeAffinity to match node zones)