New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add azure shared disk support #89511
Conversation
/test pull-kubernetes-e2e-azure-disk |
/test pull-kubernetes-e2e-azure-disk-vmss |
/hold cancel |
fix comment
/test pull-kubernetes-e2e-azure-file-windows |
/test pull-kubernetes-e2e-gce-storage-slow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
feat: add azure shared disk support
This PR only do the accessModes check when maxShares < 2
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/assign @feiskyer
/priority important-soon
/sig cloud-provider
/hold
hold for test pass first