Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Remove final user of startup-script image #89556

Merged
merged 1 commit into from Apr 7, 2020
Merged

test: Remove final user of startup-script image #89556

merged 1 commit into from Apr 7, 2020

Conversation

smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Mar 27, 2020 •
edited

It can be replaced with nc in busybox like other tests. This image has not been
pushed to gcr since 2016 and is not in the container registry schema v2.2 format
either (so modern tools may sometimes fail to work with it).

/kind cleanup
/sig network
/sig testing

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/network Categorizes an issue or PR as relevant to SIG Network. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 27, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test labels Mar 27, 2020
@smarterclayton
test: Remove final user of startup-script image
acb242f 
It can be replaced with nc in busybox like other tests.
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 27, 2020
@smarterclayton
Copy link
Contributor Author

/retest

3 similar comments
@smarterclayton
Copy link
Contributor Author

/retest

@smarterclayton
Copy link
Contributor Author

/retest

@smarterclayton
Copy link
Contributor Author

/retest

@smarterclayton
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@smarterclayton
Copy link
Contributor Author

@kubernetes/sig-network-pr-reviews PTAL

@smarterclayton
Copy link
Contributor Author

@dims do you have some review time?

dims
dims reviewed Apr 6, 2020
View reviewed changes
test/e2e/network/kube_proxy.go
@@ -229,7 +229,7 @@ var _ = SIGDescribe("Network", func() {
// a problem where spurious retransmits in a long-running TCP connection to a service
// IP could result in the connection being closed with the error "Connection reset by
// peer"
ginkgo.It("should resolve connrection reset issue #74839 [Slow]", func() {
ginkgo.It("should resolve connection reset issue #74839 [Slow]", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing typo

@dims
Copy link
Member

dims commented Apr 6, 2020

/approve
/lgtm

thanks @smarterclayton

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ac40660 into kubernetes:master Apr 7, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims left review comments

@freehan freehan Awaiting requested review from freehan

@ixdy ixdy Awaiting requested review from ixdy

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smarterclayton @dims @k8s-ci-robot