Fix client watch reestablishment handling of client-side timeouts #89652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
Nice! /lgtm |
k8s-ci-robot
added
the
lgtm
lavalamp
reviewed
Mar 30, 2020
k8s-ci-robot
removed
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Apr 8, 2020
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 9, 2020
Manual cherry pick of #89652: Fix client watch reestablishment handling of client-side timeouts
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 9, 2020
Manual cherry pick of #89652: Fix client watch reestablishment handling of client-side timeouts
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 10, 2020
Manual cherry pick of #89652: Fix client watch reestablishment handling of client-side timeouts
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 10, 2020
Manual cherry pick of #89652: Fix client watch reestablishment handling of client-side timeouts
This was referenced Aug 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes reflector behavior when it encounters watch decode errors because of client-side timeouts.
89620d5#diff-1b0009d2defb929b2d694386b30dd2acR116-R122 changed client behavior to react to errors in decoding watch events by reverting back to a full list, which is what we should do if an actual decode error occurs. However, our helper IsProbableEOF method does not detect disconnections caused by client-side timeouts, only server-side ones. When running through a proxy, server-initiated EOFs are not reliably detected by the client.
Adding client-side timeouts to the list of things IsProbableEOF considers "normal" reasons for a disconnect to occur resolves the issue.
Does this PR introduce a user-facing change?:
/cc @smarterclayton
/sig api-machinery