-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #79409: Make updateAllocatedDevices() as a public method and call it #90070
Automated cherry pick of #79409: Make updateAllocatedDevices() as a public method and call it #90070
Conversation
@RenaudWasTaken: This cherry pick PR is for a release branch and has not yet been approved by the Patch Release Team. To merge this cherry pick, please ping the kubernetes/patch-release-team in a comment, after it has been approved by the relevant OWNERS. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @dashpole |
/lgtm |
cc @derekwaynecarr @sjenning @dchen1107 @vikaschoudhary16 for visibility |
@Random-Liu could you help with this PR :) ? It's the same as #90071 and has been backported to 1.16 Thanks! |
/approve (to at least knock out one of the required approvals) |
Ah, didn't work, because I wasn't an approver yet in 1.16... |
ping @derekwaynecarr @dchen1107 Issue: In the pod resource API, Completed or Succeed pods still report the Devices that were assigned. This makes metrics reports unreliable (as Devices are still marked as "Used" by these pods). |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, klueska, RenaudWasTaken The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick of #79409 on release-1.16.
#79409: Make updateAllocatedDevices() as a public method and call it
Note that I had to resolve a small conflict with the topology_manager calling the old
updateAllocatedDevices(m.activePods())
For details on the cherry pick process, see the cherry pick requests page.