Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #79409: Make updateAllocatedDevices() as a public method and call it #90070

Conversation

RenaudWasTaken
Copy link
Contributor

@RenaudWasTaken RenaudWasTaken commented Apr 11, 2020

Cherry pick of #79409 on release-1.16.

#79409: Make updateAllocatedDevices() as a public method and call it

  • Issue: Completed or Succeed pods still report Devices assigned. This makes metrics reports unreliable.
  • Scope of the change: Limited to the beta pod-resources API
  • Risks of adding the change: This change has been running in production for at least a release.
  • Risks of associated regression: Low

Note that I had to resolve a small conflict with the topology_manager calling the old updateAllocatedDevices(m.activePods())

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot
Copy link
Contributor

@RenaudWasTaken: This cherry pick PR is for a release branch and has not yet been approved by the Patch Release Team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, please ping the kubernetes/patch-release-team in a comment, after it has been approved by the relevant OWNERS.
For details on the patch release process and schedule, see the Patch Releases page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Apr 11, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet labels Apr 11, 2020
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 11, 2020
@RenaudWasTaken
Copy link
Contributor Author

/assign @dashpole
/sig node
/kind bug
/area kubelet
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 11, 2020
@dashpole
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2020
@dashpole
Copy link
Contributor

cc @derekwaynecarr @sjenning @dchen1107 @vikaschoudhary16 for visibility

@RenaudWasTaken
Copy link
Contributor Author

@RenaudWasTaken
Copy link
Contributor Author

@Random-Liu could you help with this PR :) ? It's the same as #90071 and has been backported to 1.16
/assign @Random-Liu

Thanks!

@klueska
Copy link
Contributor

klueska commented Jun 10, 2020

/approve (to at least knock out one of the required approvals)

@klueska
Copy link
Contributor

klueska commented Jun 10, 2020

Ah, didn't work, because I wasn't an approver yet in 1.16...

@RenaudWasTaken
Copy link
Contributor Author

ping @derekwaynecarr @dchen1107
Friday, June 12 is the next cherry pick deadline ahead of June 17 patch releases

Issue: In the pod resource API, Completed or Succeed pods still report the Devices that were assigned. This makes metrics reports unreliable (as Devices are still marked as "Used" by these pods).
Scope of the change: Limited to the beta pod-resources API
Risks of adding the change: This change has been running in production for at least a release.
Risks of associated regression: Low

@derekwaynecarr
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, klueska, RenaudWasTaken

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2020
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 12, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4673741 into kubernetes:release-1.16 Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants