add beta annotations to apps #90457
Merged
add beta annotations to apps #90457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
kind/api-change
liggitt
reviewed
Apr 24, 2020
| @@ -56,6 +56,10 @@ type ScaleStatus struct { | |||
| } | |||
|
|
|||
| // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object | |||
| // +k8s:prerelease-lifecycle-gen:introduced=1.6 | |||
| // +k8s:prerelease-lifecycle-gen:deprecated=1.8 | |||
| // +k8s:prerelease-lifecycle-gen:removed=1.22 | |||
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
deads2k
force-pushed
the
beta-annotations-03-apps
branch
from
b95bc4a
to
ac2f03d
Compare
|
/lgtm |
k8s-ci-robot
added
lgtm
deads2k
force-pushed
the
beta-annotations-03-apps
branch
from
b14ccd2
to
ac2f03d
Compare
liggitt
reviewed
Apr 27, 2020
| // +k8s:prerelease-lifecycle-gen:introduced=1.6 | ||
| // +k8s:prerelease-lifecycle-gen:deprecated=1.8 | ||
| // +k8s:prerelease-lifecycle-gen:removed=1.18 | ||
| // +k8s:prerelease-lifecycle-gen:replacement=apps,v1,DeploymentRollback |
There was a problem hiding this comment.
no replacement for this API, support was removed in later versions
|
/lgtm one nit https://github.com/kubernetes/kubernetes/pull/90457/files#r416015663, follow up to drop that is fine |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the lifecycle annotation tags matching https://github.com/kubernetes/enhancements/blob/master/keps/sig-architecture/1635-prevent-permabeta/README.md
The clock is set for removal of beta levels in 1.22.
/kind cleanup
/priority important-soon
@kubernetes/sig-apps-misc @kubernetes/sig-api-machinery-misc