-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Provider/Azure] optimize mutex locks #90576
[Provider/Azure] optimize mutex locks #90576
Conversation
Hi @gaurav1086. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @feiskyer |
cc @andyzhangx |
/ok-to-test |
/kind bug |
@gaurav1086 Could you clarify the issues this PR wants to fix? have you seen performance issues with current lock? |
@feiskyer no issues. Just a proposal to enhance performance since theoretically rlock allows concurrent reading as opposed to a vanilla lock. |
OK, thanks. The change looks good. /retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, gaurav1086 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
What type of PR is this?
What this PR does / why we need it:
azure.go : use read lock when possible to allow other goroutines to read shared data concurrently.
Which issue(s) this PR fixes:
Fixes #
N/A
Special notes for your reviewer:
N/A
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: