New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set umask 0022 when building #90779
Set umask 0022 when building #90779
Conversation
Some binaries now run as non-root (kube-scheduler). When umask is 0027, for example, the container image we build has the binary 0750, which is not executable by the non-root UID.
/lgtm |
/retest |
@thockin -- do you know when this change happened i.e., how far should we cherry pick it back? /hold given that this affects a release artifact, I think it should have a release note. |
I think it has ALWAYS been present, but didn't matter because things like scheduler were running as root. Now that it's not, suddenly umask matters. You can manually check previous artifacts for the mode of the executables. If you want to backport to all living branches that would be fine with me. |
WRT release note - it shouldn't have any impact on artifacts (as far as I can guess, release-team must be using a safe umask already). If I looked at a k8s changelog and saw something about umask, I would be confused why I care. |
@justaugustus can we merge this? |
@thockin -- we sure can! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Some binaries now run as non-root (kube-scheduler). When umask is 0027,
for example, the container image we build has the binary 0750, which is
not executable by the non-root UID.
/kind bug