-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify debian-base image builds #1909
Simplify debian-base image builds #1909
Conversation
Testing via:
|
Ready for review |
@@ -27,6 +26,16 @@ COPY excludes /etc/dpkg/dpkg.cfg.d/excludes | |||
# Convenience script for building on this base image. | |||
COPY clean-install /usr/local/bin/clean-install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use --chmod here, we were seeing some failures on s390x. See #1684 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alternatively: Kubernetes fixed this upstream with umask 0022
in the build scripts and / or chmod on the host (one less layer / don't need to run it N times for each image).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I decided to add a RUN chmod +x /usr/local/bin/clean-install
to stay a bit more backwards compatible. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more recent: (umask)
what I remembered: (chmod on host)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set the umask in the Makefile
now, this should address the issue.
The usage of a temp dir is not necessary if we use the `--build-arg`/`ARG` syntax within the image build. We also do not have to assume that we're running always on x86_64, which means that the image build should now also work on arm machines for example. Signed-off-by: Sascha Grunert <mail@saschagrunert.de>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The usage of a temp dir is not necessary if we use the
--build-arg
/ARG
syntax within the image build. We also do not haveto assume that we're running always on x86_64, which means that the
image build should now also work on arm machines for example.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
/hold for manual testing
We also have to do this change for the other images if it gets accepted.
Does this PR introduce a user-facing change?