Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify how to build for or with Windows using Docker #91005

Merged
merged 1 commit into from May 14, 2020
Merged

Clarify how to build for or with Windows using Docker #91005

merged 1 commit into from May 14, 2020

Conversation

PatrickLang
Copy link
Contributor

@PatrickLang PatrickLang commented May 12, 2020 •
edited

What type of PR is this?

/kind documentation
/sig windows
/sig contributor-experience

What this PR does / why we need it:

I used to maintain a longer guide explaining how to build Kubernetes binaries for Windows, using a Windows dev box. This is much easier now, so I would like to just clarify the missing steps in the official docs, instead of keeping my own guide.

Testing details are still at https://github.com/kubernetes-sigs/windows-testing

Does this PR introduce a user-facing change?:

NONE

There is also a related change in kubernetes/community#4768. That page links to this doc if you're building in a Docker container

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/documentation Categorizes issue or PR as related to documentation. labels May 12, 2020
@k8s-ci-robot
Copy link
Contributor

@PatrickLang: The label(s) sig/contribex cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

/kind documentation
/sig windows
/sig contribex

What this PR does / why we need it:

I used to maintain a longer guide explaining how to build Kubernetes binaries for Windows, using a Windows dev box. This is much easier now, so I would like to just clarify the missing steps in the official docs, instead of keeping my own guide.

Testing details are still at https://github.com/kubernetes-sigs/windows-testing

Does this PR introduce a user-facing change?:

NONE

There is also a related change in kubernetes/community#4768. That page links to this doc if you're building in a Docker container

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 12, 2020
@PatrickLang
Copy link
Contributor Author

/retest

@PatrickLang
Copy link
Contributor Author

/assign @mikedanese

@PatrickLang
Copy link
Contributor Author

this is a doc only change, the failures I'm seeing aren't related
/retest

@BenTheElder
Copy link
Member

BenTheElder commented May 13, 2020 •
edited

these are known-flaky :/

[sig-cli] Kubectl client Simple pod should support inline execution and attach

[sig-storage] In-tree Volumes [Driver: hostPathSymlink] [Testpattern: Inline-volume (default fs)] subPath should support file as subpath [LinuxOnly]

@BenTheElder
Copy link
Member

/lgtm
/approve
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, PatrickLang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@PatrickLang
Copy link
Contributor Author

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@PatrickLang
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit a8eedc7 into kubernetes:master May 14, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 14, 2020
michmike
michmike approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@michmike michmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@marosset marosset added this to Done (v1.19) in SIG-Windows Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michmike michmike michmike approved these changes

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@BenTheElder BenTheElder

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@PatrickLang @k8s-ci-robot @BenTheElder @fejta-bot @michmike @mikedanese