Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch kube-controller-manager to distroless image #91329

Merged
merged 1 commit into from May 23, 2020
Merged

Switch kube-controller-manager to distroless image #91329

merged 1 commit into from May 23, 2020

Conversation

dims
Copy link
Member

@dims dims commented May 21, 2020 •
edited

Signed-off-by: Davanum Srinivas davanum@gmail.com

What type of PR is this?
/kind feature

What this PR does / why we need it:
We did the same for apiserver/scheduler in #90674. Withheld this change there to sync up better with sig-storage folks as this was breaking flexvolumes especially bash/shell scripts as the controller-manager no longer has required binaries to run scripts. Please see discussion in issue #78737. The plan is outlined there.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

ACTION REQUIRED : Switch core master base images (kube-controller-manager) from debian to distroless. If you need Flex Volumes support using scripts, please build your own image with required packages (like bash)

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 21, 2020
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 21, 2020
@justaugustus justaugustus added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels May 21, 2020
@dims
Copy link
Member Author

dims commented May 21, 2020

/test pull-kubernetes-e2e-kind

@dims dims force-pushed the switch-kube-controller-manager-to-distroless-image branch from 8a4bd1c to ac6674e Compare May 21, 2020 15:26
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/test sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 21, 2020
@dims dims changed the title [WIP] Switch kube-controller-manager to distroless image Switch kube-controller-manager to distroless image May 21, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2020
@dims
Copy link
Member Author

dims commented May 21, 2020

/assign @msau42 @saad-ali @dekkagaijin

@dims
Copy link
Member Author

dims commented May 21, 2020

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 21, 2020
@dims
Copy link
Member Author

dims commented May 21, 2020

/retest

@dims dims force-pushed the switch-kube-controller-manager-to-distroless-image branch from ac6674e to cbe30f2 Compare May 21, 2020 22:04
@saad-ali
Copy link
Member

/approve

Looks fine to me. Will let @msau42 review and LGTM

@dims
Copy link
Member Author

dims commented May 22, 2020

/retest

@BenTheElder
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2020
@msau42
Copy link
Member

msau42 commented May 22, 2020

Does the release note need to be an "ACTION REQUIRED"?

@dims
Switch kube-controller-manager to distroless image
b1742f1 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the switch-kube-controller-manager-to-distroless-image branch from cbe30f2 to b1742f1 Compare May 22, 2020 02:34
@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 22, 2020
@dims
Copy link
Member Author

dims commented May 22, 2020

@msau42 added ACTION REQUIRED as well.

@justaugustus
Copy link
Member

/retest

@dims
Copy link
Member Author

dims commented May 22, 2020

/test pull-kubernetes-e2e-gce-100-performance

@justaugustus
Copy link
Member

Great work, @dims! 🎉
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, justaugustus, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member

/test pull-kubernetes-kubemark-e2e-gce-big

1 similar comment
@dims
Copy link
Member Author

dims commented May 22, 2020

/test pull-kubernetes-kubemark-e2e-gce-big

@k8s-ci-robot k8s-ci-robot merged commit f01d848 into kubernetes:master May 23, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 23, 2020
@justaugustus justaugustus mentioned this pull request May 28, 2020
Closed
@tallclair tallclair mentioned this pull request May 28, 2020
Closed
10 tasks
@xlgao-zju xlgao-zju mentioned this pull request Jun 11, 2020
Open
@aojea aojea mentioned this pull request Jun 29, 2020
Merged
dims added a commit to dims/sig-release that referenced this pull request Jan 31, 2021
@dims
kube-controller-manager is already distroless
620fdd7 
kubernetes/kubernetes#78737 is closed. fixed in kubernetes/kubernetes#91329
@dims dims mentioned this pull request Jan 31, 2021
Merged
@gnufied gnufied mentioned this pull request Mar 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@justaugustus justaugustus Awaiting requested review from justaugustus

@mml mml Awaiting requested review from mml

Assignees

@justaugustus justaugustus

@BenTheElder BenTheElder

@dekkagaijin dekkagaijin

@cblecker cblecker

@saad-ali saad-ali

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@dims @saad-ali @BenTheElder @msau42 @justaugustus @k8s-ci-robot @dekkagaijin @cblecker