explicitly fail if no images are found when running remote tests #91470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation succeeds if no images are run. This causes silent failures when image matchers are provided that do not match any image.
k8s-ci-robot
added
release-note-none
Nice, that's what I expected to see. Looks like I can debug by whack-a-mole if necessary. |
bsdnet
approved these changes
May 27, 2020
|
@MHBauer Thank you for the PR. 2 observations:
Thoughts? |
|
I think failing is informing. Can we configure test-infra image bumper to look at cos? |
|
i agree failing loudly is preferred. /retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, MHBauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
bsdnet
reviewed
Jun 1, 2020
| @@ -244,6 +244,10 @@ func main() { | |||
| klog.Fatalf("Could not retrieve list of images based on image prefix %q and family %q: %v", | |||
| imageConfig.ImageRegex, imageConfig.ImageFamily, err) | |||
| } | |||
| if len(images) == 0 { // if we have no images we can't run anything | |||
There was a problem hiding this comment.
It will be cleaner to put this into the function rather than outside. See #91543
|
/retest Review the full test history for this PR. Silence the bot with an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation succeeds if no images are run. This causes
silent failures when image matchers are provided that do not match any image.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Some of the root cause of this existing in the first place.
#91292
In this issue we can see that in april some images were updated, and tests stopped running at all for 2 of 3 images.
Special notes for your reviewer:
With a list of no images, it turns a bunch of the later for loops into nops, because we
for _,_ := rangeover an empty container.Ya'll looked at the issue:
/cc @spiffxp @vpickard @bart0sh @dims
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
I think tests should fail if they don't run.
I'm not sure how to test this.
This has potential to cause anything using image-regex, image_regex, image-family, image_family matchers to fail loudly.
/hold