Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debugging and timeouts to pending pod e2e #91585

Merged
merged 1 commit into from May 30, 2020
Merged

Add debugging and timeouts to pending pod e2e #91585

merged 1 commit into from May 30, 2020

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented May 29, 2020

What type of PR is this?
/kind flake

What this PR does / why we need it:
Adds debugging and timeouts to a test that is encountering timeouts

Which issue(s) this PR fixes:
xref #91579

Does this PR introduce a user-facing change?:

NONE

/cc @BenTheElder @smarterclayton @aojea

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 29, 2020
@liggitt liggitt mentioned this pull request May 29, 2020
Closed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 29, 2020
@wojtek-t
Copy link
Member

/lgtm

Thanks Jordan!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2020
@liggitt
Copy link
Member Author

liggitt commented May 29, 2020

/test pull-kubernetes-e2e-kind

@liggitt
Copy link
Member Author

liggitt commented May 29, 2020

/retest

2 similar comments
@liggitt
Copy link
Member Author

liggitt commented May 29, 2020

/retest

@wojtek-t
Copy link
Member

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@wojtek-t
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6468bfa into kubernetes:master May 30, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 30, 2020
@liggitt liggitt deleted the pending-pod-timeout branch June 2, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liggitt @k8s-ci-robot @wojtek-t @fejta-bot