Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump k8s.io/utils to 6e3d28 to pick up nested trace #91634

Merged
merged 1 commit into from Jun 23, 2020
Merged

Bump k8s.io/utils to 6e3d28 to pick up nested trace #91634

merged 1 commit into from Jun 23, 2020

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Jun 1, 2020 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Picks up nested tracing support (kubernetes/utils#139) which is needed by #88936

Special notes for your reviewer:

hack/pin-dependency.sh k8s.io/utils 24a76e807f40c05aee600673f7f38f88d0ab254f
hack/update-vendor.sh

Does this PR introduce a user-facing change?:

no

NONE

/priority important-longterm
/sig api-machinery
/cc @sttts @somtochiama @thockin

@k8s-ci-robot k8s-ci-robot requested a review from sttts June 1, 2020 15:55
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 1, 2020
@k8s-ci-robot
Copy link
Contributor

@jpbetz: GitHub didn't allow me to request PR reviews from the following users: SomtochiAma.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it:

Picks up nested tracing support (kubernetes/utils#139) which is needed by #87610 and #88936

Special notes for your reviewer:

hack/pin-dependency.sh k8s.io/utils 24a76e807f40c05aee600673f7f38f88d0ab254f
hack/update-vendor.sh

Does this PR introduce a user-facing change?:

no

NONE

/priority important-longterm
/sig api-machinery
/cc @sttts @somtochiama @thockin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jun 1, 2020
@k8s-ci-robot k8s-ci-robot requested a review from thockin June 1, 2020 15:55
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Jun 1, 2020
@jpbetz
Copy link
Contributor Author

jpbetz commented Jun 1, 2020

/retest

@jpbetz jpbetz mentioned this pull request Jun 1, 2020
Merged
@sttts
Copy link
Contributor

sttts commented Jun 2, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2020
@jpbetz
Copy link
Contributor Author

jpbetz commented Jun 2, 2020

/assign @thockin

@jpbetz
Copy link
Contributor Author

jpbetz commented Jun 2, 2020

cc @dims

@dims
Copy link
Member

dims commented Jun 2, 2020

@jpbetz please hold this. this brings in a change that is being tested in another PR #91468 and is running into trouble. Also looks like we may have a fix in progress for that issue in kubernetes/utils#169

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2020
@jpbetz
Copy link
Contributor Author

jpbetz commented Jun 2, 2020

Thanks @dims. I'll wait for the other bump of utils to resolve, and if it pull in a newer version than I needed, I'll just close this. Holding..

@andyzhangx
Copy link
Member

@jpbetz please hold this. this brings in a change that is being tested in another PR #91468 and is running into trouble. Also looks like we may have a fix in progress for that issue in kubernetes/utils#169

/hold

thanks. it has trouble in unmount volume on windows node

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2020
@jpbetz jpbetz mentioned this pull request Jun 19, 2020
Closed
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2020
@jpbetz jpbetz changed the title Bump k8s.io/utils to 24a76e to pick up nested trace Bump k8s.io/utils to 6e3d28 to pick up nested trace Jun 19, 2020
@jpbetz
Copy link
Contributor Author

jpbetz commented Jun 19, 2020

/hold cancel

kubernetes/utils#173 reverts the PR that broke utils (see #91634 (comment)). Updated this PR to pick up the latest commit of utils.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2020
@jpbetz
Copy link
Contributor Author

jpbetz commented Jun 19, 2020

test timeouts

/retest

@jpbetz
Copy link
Contributor Author

jpbetz commented Jun 19, 2020

Integration tests seems to be consistently failing on TestSecretsShouldBeTransformed:

I0619 18:41:48.847732  116423 storage_scheduling.go:143] all system priority classes are created successfully or already exist.
panic: test timed out after 10m0s

@jpbetz
Copy link
Contributor Author

jpbetz commented Jun 22, 2020

Different integration test failure on last run, rebasing and retrying.

@jpbetz
Copy link
Contributor Author

jpbetz commented Jun 22, 2020

/retest

@jpbetz
Copy link
Contributor Author

jpbetz commented Jun 22, 2020

test timeout

/retest

@jpbetz
Copy link
Contributor Author

jpbetz commented Jun 22, 2020

/retest

@jpbetz
Copy link
Contributor Author

jpbetz commented Jun 22, 2020

@dims would you have a look? This is with the PR that broke untold rolled back.

@dims
Copy link
Member

dims commented Jun 22, 2020

/approve
/lgtm

/assign @liggitt

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2020
@liggitt
Copy link
Member

liggitt commented Jun 22, 2020

/retest

@liggitt
Copy link
Member

liggitt commented Jun 22, 2020

/approve
vendor mechanics lgtm
azure-file-windows CI passed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, jpbetz, liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2020
@k8s-ci-robot
Copy link
Contributor

@jpbetz: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce 52838be link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jpbetz
Copy link
Contributor Author

jpbetz commented Jun 23, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit a7e4973 into kubernetes:master Jun 23, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 23, 2020
@liggitt liggitt mentioned this pull request Jul 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts Awaiting requested review from sttts

@thockin thockin Awaiting requested review from thockin

Assignees

@dims dims

@sttts sttts

@liggitt liggitt

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jpbetz @k8s-ci-robot @sttts @dims @andyzhangx @jingxu97 @liggitt @thockin