Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSR v1 - add support to kubectl certificate commands #91778

Merged
merged 1 commit into from
Jun 10, 2020
Merged

CSR v1 - add support to kubectl certificate commands #91778

merged 1 commit into from
Jun 10, 2020

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jun 4, 2020 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • Adds support for v1 CSRs to kubectl certificate commands, falling back to v1beta1 if v1 is unavailable
  • Adds unit test coverage

xref kubernetes/enhancements#1513

Does this PR introduce a user-facing change?:

NONE

/milestone v1.19
/priority important-soon
/sig auth
/cc @munnerz @deads2k

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/auth Categorizes an issue or PR as relevant to SIG Auth. labels Jun 4, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 4, 2020
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 4, 2020
@liggitt liggitt mentioned this pull request Jun 4, 2020
Merged
6 tasks
@k8s-ci-robot k8s-ci-robot added area/apiserver area/conformance Issues or PRs related to kubernetes conformance tests area/kubectl area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 4, 2020
@liggitt liggitt mentioned this pull request Jun 4, 2020
Merged
7 tasks
@liggitt liggitt force-pushed the kubectl-approve-v1 branch 3 times, most recently from 8f8051f to cb2774b Compare June 5, 2020 05:15
@liggitt
Copy link
Member Author

liggitt commented Jun 5, 2020

/retest

@liggitt liggitt changed the title WIP - CSR v1 - add support to kubectl certificate commands CSR v1 - add support to kubectl certificate commands Jun 5, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2020
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt
Copy link
Member Author

liggitt commented Jun 5, 2020

/retest

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2020
@liggitt liggitt removed area/apiserver area/conformance Issues or PRs related to kubernetes conformance tests area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 5, 2020
@liggitt
Copy link
Member Author

liggitt commented Jun 6, 2020

/retest

4 similar comments
@liggitt
Copy link
Member Author

liggitt commented Jun 6, 2020

/retest

@liggitt
Copy link
Member Author

liggitt commented Jun 6, 2020

/retest

@liggitt
Copy link
Member Author

liggitt commented Jun 6, 2020

/retest

@liggitt
Copy link
Member Author

liggitt commented Jun 6, 2020

/retest

@liggitt liggitt mentioned this pull request Jun 7, 2020
Closed
@liggitt
Copy link
Member Author

liggitt commented Jun 9, 2020

/assign @soltysh

@liggitt liggitt requested review from soltysh and removed request for deads2k June 9, 2020 16:25
seans3
seans3 approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@seans3 seans3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 79123e5 into kubernetes:master Jun 10, 2020
@liggitt liggitt deleted the kubectl-approve-v1 branch June 11, 2020 02:34
@wking wking mentioned this pull request Jul 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seans3 seans3 seans3 approved these changes

@munnerz munnerz Awaiting requested review from munnerz

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@soltysh soltysh

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
5 participants
@liggitt @fejta-bot @k8s-ci-robot @seans3 @soltysh